From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0859D3238 for ; Thu, 26 Jul 2018 16:18:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7A61021D2C; Thu, 26 Jul 2018 10:18:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 10:18:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=dY9WbZoNve5kcoX94HmUzpcTHd /ZaaKZDGFNrT4WDzI=; b=gbLb9n6L78tCJ6fMx9lq5GjHjgzxbvDrrAldF2q095 DfBdHvgUNb6KFfiDCpKk+xOMWQYGNYCz0V+Ni7WNK76QQg4N5RXFur6Ec3QsNBGz YovIO23y1GBakFKKh8VyDe7VOFJKGO5R4tb80vNGsFEpusJSHlugXoso7g8QrOCo E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=dY9WbZ oNve5kcoX94HmUzpcTHd/ZaaKZDGFNrT4WDzI=; b=ibCQz8XjRLvu3mhD0XN4eO gCtyB4NHWOfYZVzNO0cDxf7wclOZ0QpZ8vYhNAPZOux7VHlbmpiqSz9hSxWtrX95 b/Jylsctp8jMkMLiVvVvqNB08twFUesUBpYivrF6Ci07HHChdYTJTuZ5MaC39rIi mOyjisF+1X6GBEhYyGuK1mwSl5+4AEwIuWvK1zSeg6PjhgSy7Nknmoal9t/oy2fB fyFGMw1U72kvlXWa2g+zwJLjacmSBexwcSsncNPHzJtuBOmxP0aXPdpcT1DXUMQZ kHWDWZqgTmZeVejQQXa5MD+wEM1/4B+FBhsD05gqRzdKHhY8iOUGw1QjAO2NYyGA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AAFD21025D; Thu, 26 Jul 2018 10:18:15 -0400 (EDT) From: Thomas Monjalon To: Harry van Haaren Cc: dev@dpdk.org, vipin.varghese@intel.com Date: Thu, 26 Jul 2018 16:18:11 +0200 Message-ID: <2376975.KA9Fdbqaqj@xps> In-Reply-To: <2874140.BQP81VYxLs@xps> References: <1526399782-156061-1-git-send-email-harry.van.haaren@intel.com> <1531502739-121073-1-git-send-email-harry.van.haaren@intel.com> <2874140.BQP81VYxLs@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 14:18:17 -0000 Hi Harry, Are you OK to make a v4? 13/07/2018 19:33, Thomas Monjalon: > 13/07/2018 19:25, Harry van Haaren: > > v3: > > - Use WARNING instead of ERR log level (Vipin) > > - Put strings on one line for grep-ability (Harry) > > We can consider it is OK to have sentences on different lines. > Who is grepping 2 sentences at once? > > > v2, thanks for review: > > - Consistency in message endings - vs . (Thomas) > > Some dots are missing. > > > - Wrap lines as they're very long otherwise (Thomas) > > Lines are not wrapped. > > > + RTE_LOG(WARNING, EAL, > > + "Service cores parsed before dataplane cores Please ensure -c is before -s or -S.\n"); > > I think this would be better: > > RTE_LOG(WARNING, EAL, > "Service cores parsed before dataplane cores. " > "Please ensure -c is before -s or -S.\n");