From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx: fix variadic macro
Date: Thu, 12 Dec 2019 23:24:21 +0100 [thread overview]
Message-ID: <2378185.bRGs8SLAUz@xps> (raw)
In-Reply-To: <20191211064826.16314-1-alialnu@mellanox.com>
11/12/2019 07:49, Ali Alnubani:
> This rewrites the MKSTR macro appending an empty string to its arguments
> to resolve build failures similar to:
>
> drivers/net/mlx4/mlx4.c:461:14: fatal error: format string is not a
> string literal [-Wformat-nonliteral]
> MKSTR(path, "%s/device/uevent", device->ibdev_path);
>
> drivers/net/mlx4/mlx4_utils.h:82:30: note: expanded from macro 'MKSTR'
> char name[snprintf(NULL, 0, __VA_ARGS__) + 1]; \
>
> drivers/net/mlx5/mlx5_stats.c:144:15: fatal error: format string is not a
> string literal [-Wformat-nonliteral]
> MKSTR(path, "%s/ports/%d/hw_counters/%s",
>
> drivers/net/mlx5/mlx5_utils.h:149:30: note: expanded from macro 'MKSTR'
> char name[snprintf(NULL, 0, __VA_ARGS__) + 1]; \
>
> The errors reproduce with clang version 9.0.0, and the release notes
> don't mention what could have caused them.
>
> Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
> Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters")
> Cc: adrien.mazarguil@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Applied quickly in main tree as it is fixing compilation with a recent clang 9.
prev parent reply other threads:[~2019-12-12 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 6:49 Ali Alnubani
2019-12-12 22:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2378185.bRGs8SLAUz@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).