From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
dpdk-dev <dev@dpdk.org>,
"techboard@dpdk.org" <techboard@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>, nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
Date: Sat, 18 Jan 2020 01:06:39 +0100 [thread overview]
Message-ID: <2379528.o2A3GueYyp@xps> (raw)
In-Reply-To: <AM6PR08MB5144509413B1DDBECCADA9A798310@AM6PR08MB5144.eurprd08.prod.outlook.com>
17/01/2020 16:48, Honnappa Nagarahalli:
> > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > > > >> --- a/config/common_linux
> > > > > >> +++ b/config/common_linux
> > > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > > > >>
> > > > > >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > > > >> CONFIG_RTE_EAL_VFIO=y
> > > > > >> -CONFIG_RTE_KNI_KMOD=y
> > > Suggest to keep the lines, but set them to 'n'. It will be easier to enable.
Configs should be enabled in the generated .config,
not in the versioned template.
> > In config/common_base it is set as =n. it can be enabled there just like other
> > config.
> > I just did this way to have symmetry with other configs.
> > Thoughts?
> Sounds good.
> CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=n can also be removed as it is set in common_base.
> CONFIG_RTE_LIBRTE_VHOST_POSTCOPY is set to 'n' in common_linux, but it is not present in common_base.
Good catch.
All options should be in common_base.
next prev parent reply other threads:[~2020-01-18 0:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 13:13 [dpdk-dev] " jerinj
2020-01-16 13:11 ` Jerin Jacob
2020-01-16 18:33 ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
2020-01-16 18:43 ` Jerin Jacob
2020-01-16 22:38 ` Honnappa Nagarahalli
2020-01-17 4:07 ` Jerin Jacob
2020-01-17 15:48 ` Honnappa Nagarahalli
2020-01-18 0:06 ` Thomas Monjalon [this message]
2020-01-17 8:29 ` Maxime Coquelin
2020-01-17 9:19 ` Kevin Traynor
2020-01-17 9:55 ` Jerin Jacob
2020-01-17 19:14 ` [dpdk-dev] [PATCH v2] " jerinj
2020-01-20 17:42 ` Thomas Monjalon
2020-02-12 17:18 ` Lipiec, Herakliusz
2020-02-12 17:39 ` Thomas Monjalon
2020-01-22 6:34 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2020-01-22 9:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2379528.o2A3GueYyp@xps \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=maxime.coquelin@redhat.com \
--cc=nd@arm.com \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).