From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C04CDA051C; Sat, 18 Jan 2020 01:06:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A174D2A6C; Sat, 18 Jan 2020 01:06:43 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A671A29C6; Sat, 18 Jan 2020 01:06:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 249B421B8C; Fri, 17 Jan 2020 19:06:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 17 Jan 2020 19:06:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PTFbSH8lC3aR/mkpquJUHquOMnInjzIvdAtbyOgf80g=; b=cWuKm36mccxa s8/ai/0Efi8Y2iuU9YWLBFuw8crjl4n/C/n3L1sqFBivd/w15d+UYw8571AHqnBP fgg/3kq5LsZIrjajgJlRugASdWz/9CetZnl/fd+XK2YAYgPoHNCKaDNBVv69PzMn ty4y3LLEJie+BwmqzxWpIi5H6cIxVLQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PTFbSH8lC3aR/mkpquJUHquOMnInjzIvdAtbyOgf8 0g=; b=sFf0d9zuKTTql+5FXrFwC9mAgE+y7rGmNM4sIQIIlQAUNkxa+FmPK13b/ B6s2Vua7Q5X1SFVNJWoGfws6V0uGhRWNwcNOeWrSFiQzB8IZhptqCfdMkPnfOmmC 8LXeTTN7mx8GDkTRvVb31NdxiQi0I8TevTZYUU63SXWQI6GWFZ0813XU1mPGU2Uc /g+sESJ18PglrUnTFojVQtqAfGKpYoWDZvHq8mxjoRIfN/hT9yOhsQHm9Y0KjHQU dWA8tWDAQb2u/Mz4DmO86vKOYV2EBKYDh5gtv13okMIrcCroP3b2CrhZCPsVGEad O560+93TS+JFzcQSAetXWngkEwn1Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrtdelgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E8CD80060; Fri, 17 Jan 2020 19:06:40 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob , Honnappa Nagarahalli Cc: Maxime Coquelin , "jerinj@marvell.com" , dpdk-dev , "techboard@dpdk.org" , "Richardson, Bruce" , nd , Honnappa Nagarahalli , nd Date: Sat, 18 Jan 2020 01:06:39 +0100 Message-ID: <2379528.o2A3GueYyp@xps> In-Reply-To: References: <20191212131302.1626130-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/01/2020 16:48, Honnappa Nagarahalli: > > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > > > > > On Thu, Dec 12, 2019 at 6:42 PM wrote: > > > > > >> --- a/config/common_linux > > > > > >> +++ b/config/common_linux > > > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y > > > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y > > > > > >> > > > > > >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > > > > > >> -CONFIG_RTE_EAL_IGB_UIO=y > > > > > >> CONFIG_RTE_EAL_VFIO=y > > > > > >> -CONFIG_RTE_KNI_KMOD=y > > > Suggest to keep the lines, but set them to 'n'. It will be easier to enable. Configs should be enabled in the generated .config, not in the versioned template. > > In config/common_base it is set as =n. it can be enabled there just like other > > config. > > I just did this way to have symmetry with other configs. > > Thoughts? > Sounds good. > CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=n can also be removed as it is set in common_base. > CONFIG_RTE_LIBRTE_VHOST_POSTCOPY is set to 'n' in common_linux, but it is not present in common_base. Good catch. All options should be in common_base.