From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Michal Berger <michallinuxstuff@gmail.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2] buildtools: fix build with meson 0.60
Date: Wed, 03 Nov 2021 14:32:18 +0100 [thread overview]
Message-ID: <2379909.PSPGR8f3mN@thomas> (raw)
In-Reply-To: <6875802.xvGM9SWLx5@thomas>
03/11/2021 14:20, Thomas Monjalon:
> 02/11/2021 19:08, Dmitry Kozlyuk:
> > 2021-11-01 17:03 (UTC+0000), Bruce Richardson:
> > > Meson 0.60 switched the format of uninstalled static libraries
> > > to thin archives, that is, they contain only paths to object files,
> > > not the files themselves. Files cannot be extracted in this case,
> > > resulting in build errors:
> > >
> > > ar: `x' cannot be used on thin archives.
> > >
> > > Handle thin archives when invoking pmdinfogen by directly using the
> > > files referenced in the archive, when they already exist, and extracting
> > > them if not.
> > >
> > > Bugzilla ID: 836
> > > Fixes: e6e9730c7066 ("buildtools: support object file extraction for Windows")
> > > Cc: stable@dpdk.org
> > >
> > > Reported-by: Michal Berger <michallinuxstuff@gmail.com>
> > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > LGTM.
> > Note: meson 0.60 can't build DPDK on Windows due to a meson bug,
> > but *.pmd.c generation stage passes OK.
>
> Should we add this comment in the commit log?
> Knowing that Windows build is broken looks to be an interesting info.
> Should we add a known issue in the release notes?
It seems the issue on Windows is older than Meson 0.60,
so no additional info is needed in this commit.
A separate update can be done for this Windows-specific issue.
Applied, thanks.
prev parent reply other threads:[~2021-11-03 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 19:32 [dpdk-dev] [PATCH] " Dmitry Kozlyuk
2021-10-27 10:53 ` Bruce Richardson
2021-10-27 16:16 ` Bruce Richardson
2021-10-27 16:45 ` Dmitry Kozlyuk
2021-11-01 16:54 ` Bruce Richardson
2021-11-01 17:36 ` Dmitry Kozlyuk
2021-11-01 17:03 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2021-11-02 18:08 ` Dmitry Kozlyuk
2021-11-03 13:20 ` Thomas Monjalon
2021-11-03 13:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2379909.PSPGR8f3mN@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=michallinuxstuff@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).