From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1F7CF2C16
 for <dev@dpdk.org>; Fri,  4 Aug 2017 00:50:26 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id BB44620832;
 Thu,  3 Aug 2017 18:50:25 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Thu, 03 Aug 2017 18:50:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=UxQ1rC+mjNVFrdp
 230MSqKczVg/k+N5J0cI7rHJifv4=; b=ZDbM49wzoZRedWr0Ikcq4pPtpFoarah
 /N0rcaz2cjKTrLCG91MjucGgFs8uJOfevx9agnCgmz9BdoZoFE3613av1ObkPLMe
 fjjbNdL/+2AFAw2iWblC22GqseURlPRlvEEn2wjz64tY5+GB99udtkEXpFIhab/6
 D3U2WuT/U898=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=UxQ1rC+mjNVFrdp230MSqKczVg/k+N5J0cI7rHJifv4=; b=AYt7Zgvy
 g3106V9TT4LaHG4LubOvLFX1pK8quBiWWdNepSqeCDA0zK+AmROu18gNZPwuK2Ya
 jSohq9VE79GJJrx+cejYB0A+JLInqTVoMlJ3COQ3WCV43iYm7Ala0PjNQKJ7jUcj
 9dxk5XnQ7fr656IusuqhZeHDtWF+9wAS1sHc3tbDmLIMCahYa7UjqboAI5ACimTP
 XsIWhiEoTTt1vyMAS9GwGeTBg35SNVF4sx6RNPlOzVMP9Ov2Ndw3I63vT3Jqj66G
 b6W5+aK7Tbqaf2MjI1EgwhAqn3d5qY2/R+gVJE+EhqBKWRyXSrNrCe+zNzI5Xls0
 4biD4qceI+HttQ==
X-ME-Sender: <xms:saiDWWoH6gbPWmC380nYYcrmPGgnZltjrZ6KNUBr-r58sg6bNdYfEg>
X-Sasl-enc: hb/YzG33Wv4QXcNBuNKXv79WQ/aoWsEJ+rcV3y9o/Ge2 1501800625
Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196])
 by mail.messagingengine.com (Postfix) with ESMTPA id 5C0427E5EC;
 Thu,  3 Aug 2017 18:50:25 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: dev@dpdk.org
Date: Fri, 04 Aug 2017 00:50:24 +0200
Message-ID: <2383964.bQBCqqHOqo@xps>
In-Reply-To: <1499447399-9467-1-git-send-email-erik.g.carrillo@intel.com>
References: <1496699017-98327-1-git-send-email-erik.g.carrillo@intel.com>
 <1499447399-9467-1-git-send-email-erik.g.carrillo@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3] doc: add new targets to "make help" output
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 22:50:26 -0000

Hi,

Sorry for the very very late review.

07/07/2017 19:09, Gabriel Carrillo:
> Commit aafaea3d3b70 ("devtools: add tags
> and cscope index generation") introduced
> new make targets. This change updates the
> help target output to reflect the additions.
> 
> Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> +	tags|gtags T=    generate tags/gtags for given targets (T=)
> +	cscope T=        generate cscope database for given targets (T=)

No need of T= in the first column.
It is specified only for install which has two different meanings
with and without T=.

You should also add etags I think.