From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file
Date: Fri, 12 Jan 2018 19:02:27 +0100 [thread overview]
Message-ID: <2386533.Y8nkdzO727@xps> (raw)
In-Reply-To: <4a54e295890a75b513176c62f83f87b67817baa4.1515777134.git.anatoly.burakov@intel.com>
12/01/2018 18:49, Anatoly Burakov:
> Unlike every other DPDK application's compilation, proc_info's
> compilation cannot be turned off on Linux. Fix it by adding a
> config option to base linuxapp config.
>
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tahhan@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> app/Makefile | 2 +-
> config/common_linuxapp | 1 +
You should also add the option in common_base (as disabled),
so we keep the list of almost every options in one place.
next prev parent reply other threads:[~2018-01-12 18:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 14:17 [dpdk-dev] [PATCH] app: fix proc_info app dependency Anatoly Burakov
2018-01-12 14:59 ` Thomas Monjalon
2018-01-12 15:04 ` Burakov, Anatoly
2018-01-12 15:41 ` Thomas Monjalon
2018-01-12 17:49 ` [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file Anatoly Burakov
2018-01-12 18:02 ` Thomas Monjalon [this message]
2018-01-12 18:05 ` Burakov, Anatoly
2018-01-12 18:27 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2018-01-17 18:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2386533.Y8nkdzO727@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).