From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D192A16E;
 Fri, 12 Jan 2018 19:02:59 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6260521495;
 Fri, 12 Jan 2018 13:02:59 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Fri, 12 Jan 2018 13:02:59 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=6GFuqlKQIa1FnsEegVQQWq1rz2
 5hV/zWsRXqZjrZkTU=; b=huj6/oQm/yk5Wt8NfSl+R2MFx5ebmqUPUvuMbfwiug
 CX15fz5wcFwVMaWBnOAbnCjUzSD29A4HeJvmmwVrLaUaH2fm1pskRaIK7/xJ+9K2
 b+Q9BqpTShVWsKHGoFxkn5znXdLTIHTeNXoh87kmSoZQ8j+9eilGmEuH5FwdujDp
 w=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=6GFuql
 KQIa1FnsEegVQQWq1rz25hV/zWsRXqZjrZkTU=; b=DcZVie7VfiFu2fyTTA90Sl
 eB17/ZpeiwJqdB5ls8Lkg+aedcHZ645YXx6qC6EaaFDpQQVzAf6nZD2Hq56JTe12
 fdazbudlep4QpxM1iK0pQw7W+8ZqZ+kUWYn7bIZgMKzvFpeddedXzp2WOwqA2IDO
 9fEwN96QXXuga1OFNLT2yvL1ya25xOEbfXIi3CZSjqc8I5yTbB4RgsDzZdAlYLK/
 ucxOEbOhzH25XeRRYfrOGbjr/2UlF2sYPMnCeS2dnJnVdKafYsqaUXQPdWO0pWhe
 JEVZbbZOc4cBd5/fzjUWkDHfV30eXVdXak1hQJTD+GvodDiAoa+TPtVKPsrk/o6A
 ==
X-ME-Sender: <xms:U_hYWnck0oguEQN68tAhV87W9kXKevm71nfObJ67F67hjWx78uS0OQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E947A24838;
 Fri, 12 Jan 2018 13:02:56 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org
Date: Fri, 12 Jan 2018 19:02:27 +0100
Message-ID: <2386533.Y8nkdzO727@xps>
In-Reply-To: <4a54e295890a75b513176c62f83f87b67817baa4.1515777134.git.anatoly.burakov@intel.com>
References: <ab9cedc7976ffda3060682a55d15d0cb187ad248.1515765793.git.anatoly.burakov@intel.com>
 <4a54e295890a75b513176c62f83f87b67817baa4.1515777134.git.anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in
	config file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jan 2018 18:03:00 -0000

12/01/2018 18:49, Anatoly Burakov:
> Unlike every other DPDK application's compilation, proc_info's
> compilation cannot be turned off on Linux. Fix it by adding a
> config option to base linuxapp config.
> 
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tahhan@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  app/Makefile           | 2 +-
>  config/common_linuxapp | 1 +

You should also add the option in common_base (as disabled),
so we keep the list of almost every options in one place.