From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC189A00C2; Thu, 6 Oct 2022 12:34:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 927DB42BF0; Thu, 6 Oct 2022 12:34:07 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id E493442B70 for ; Thu, 6 Oct 2022 12:34:05 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id ED0B03200905; Thu, 6 Oct 2022 06:34:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 06 Oct 2022 06:34:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1665052441; x= 1665138841; bh=RTddVFKx02FUf23PIBf3iL7GSpmrop6yDKOfqK2AtmU=; b=M g9r8i/o/LOS1j2Z0K+/GlpMCi3FYtmT6Xfqwi46pRi/icu/XsD41wfGSqFlMBab+ rSshZVKr93FgQXlWqEWbj2EAdUtCqSfe/SAzbgExmfPF3EArk0X7jaApoaptCKxu QPzSBJlhd+8ZezNiLJKRdsbvo97xwYfE98K90WwBSL00GTw0AT6ibDFvmRCfsEPi OJSAWul8wv1ReH1ccKuXOLP5/2hqo8KWw7wuPeGu15JFex2e6GKiynoCnkVWXIeN dKdxJGm0J+x+rGwOr+mOHno+EY0D8EKit0u3XNnmP4bvrgVZGYdka2wN6XWIPyn3 0CPhcoqiWn9pbEPDjyN6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1665052441; x= 1665138841; bh=RTddVFKx02FUf23PIBf3iL7GSpmrop6yDKOfqK2AtmU=; b=O zs8t+ow2zWU4swZGL5akq7bniakGJOGSjI7kQr/2m2V47qJ5jmzTT8xFoL4q0F75 Sh+TVtNSVebAPi/4UAaFlBVtq+N2a3o/BEp4JWuu/xy98legHhnKB4cs/tfD+10x zi+faWxms6Lg1g5FN8J5mTEEkdcoILVPHayR215QvGDTmMkt6ZlbfR6Yz4gPH4wm F44txQGnlwhLUabQep0ya8c6dtLDCXm/9vRzWmTilQbEY4leJIiBSeye75VeaTfm 6JcxuKq72ND0fi8Hnj8jZ2c+b3wJsl62p9kjWas6CsNcLmNjMVYfMe9AWraybfV+ h/GG+qeN29SQib++dmAfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeihedgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Oct 2022 06:34:00 -0400 (EDT) From: Thomas Monjalon To: Kevin Traynor Cc: dev@dpdk.org, Tomasz Kantecki , Bruce Richardson , Dmitry Kozlyuk , David Marchand Subject: Re: [PATCH] examples/l2fwd-cat: fix build Date: Thu, 06 Oct 2022 12:33:59 +0200 Message-ID: <2386930.jE0xQCEvom@thomas> In-Reply-To: References: <20221005152347.330954-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/10/2022 17:28, David Marchand: > On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor wrote: > > > > and need to be included for the build > > since they were removed from . > > > > ../examples/l2fwd-cat/cat.c: In function =E2=80=98parse_set=E2=80=99: > > ../examples/l2fwd-cat/cat.c:66:16: > > warning: implicit declaration of function =E2=80=98isblank=E2=80=99 > > [-Wimplicit-function-declaration] > > 66 | while (isblank(*str)) > > | ^~~~~~~ > > ../examples/l2fwd-cat/cat.c:18:1: > > note: include =E2=80=98=E2=80=99 or provide a declaration of = =E2=80=98isblank=E2=80=99 > > 17 | #include "cat.h" > > +++ |+#include > > 18 | > > ../examples/l2fwd-cat/cat.c:70:15: > > warning: implicit declaration of function =E2=80=98isdigit=E2=80=99 > > [-Wimplicit-function-declaration] > > 70 | if ((!isdigit(*str) && *str !=3D '(') || *str =3D=3D '\= 0') > > | ^~~~~~~ > > ../examples/l2fwd-cat/cat.c:70:15: > > note: include =E2=80=98=E2=80=99 or provide a declaration of = =E2=80=98isdigit=E2=80=99 > > ../examples/l2fwd-cat/cat.c:75:17: > > error: =E2=80=98errno=E2=80=99 undeclared (first use in this function) > > 75 | errno =3D 0; > > | ^~~~~ > > ../examples/l2fwd-cat/cat.c:18:1: > > note: =E2=80=98errno=E2=80=99 is defined in header =E2=80=98= =E2=80=99; > > did you forget to =E2=80=98#include =E2=80=99? > > 17 | #include "cat.h" > > +++ |+#include > > > > Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public heade= r") > > > > Signed-off-by: Kevin Traynor > Reviewed-by: David Marchand Applied, thanks.