From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, shahafs@mellanox.com, olgas@mellanox.com,
rasland@mellanox.com
Subject: Re: [dpdk-dev] [PATCH 2/2] malloc: avoid padding elements on page deallocation
Date: Wed, 02 May 2018 18:28:03 +0200 [thread overview]
Message-ID: <2387384.z8u5O1jZH9@xps> (raw)
In-Reply-To: <454d2b8eea6615a20e496fa924cc04feda9bb686.1525274971.git.anatoly.burakov@intel.com>
02/05/2018 17:38, Anatoly Burakov:
> Currently, when deallocating pages, malloc will fixup other
> elements' headers if there is not enough space to store a full
> element in leftover space. This leads to race conditions because
> there are some functions that check for pad size with an unlocked
> heap, expecting pad size to be constant.
>
> Fix it by being more conservative and only freeing pages when
> there is enough space before and after the page to store a free
> element.
>
> Fixes: 1403f87d4fb8 ("malloc: enable memory hotplug support")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Series applied, thanks.
(typo fixed and added uppercase at beginning of sentences)
prev parent reply other threads:[~2018-05-02 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 15:38 [dpdk-dev] [PATCH 1/2] malloc: set pad to 0 on free Anatoly Burakov
2018-05-02 15:38 ` [dpdk-dev] [PATCH 2/2] malloc: avoid padding elements on page deallocation Anatoly Burakov
2018-05-02 16:28 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2387384.z8u5O1jZH9@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).