From: Thomas Monjalon <thomas@monjalon.net>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Ophir Munk <ophirmu@mellanox.com>,
dev@dpdk.org, Olga Shern <olgas@mellanox.com>,
Shahaf shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling
Date: Mon, 26 Mar 2018 14:30:34 +0200 [thread overview]
Message-ID: <2388926.RzC4zprzFL@xps> (raw)
In-Reply-To: <20180326115452.GF4011@6wind.com>
26/03/2018 13:54, Adrien Mazarguil:
> On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote:
> > On 3/25/2018 9:19 PM, Ophir Munk wrote:
> > > Previous to this commit mlx4 CRC stripping was executed by default and
> > > there was no verbs API to disable it.
> >
> > Are you aware of the discussion about CRC [1]? Is this patch compatible with plans?
> >
> > [1]
> > https://dpdk.org/dev/patchwork/patch/36415/
>
> I wasn't aware of this notice. Looks like it makes this patch unnecessary
> since mlx4 always strip by default; this patch makes it configurable at will
> and only exposes the capability when HW supports its configuration (i.e. the
> ability to leave CRC inside mbuf).
>
> We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in
> mlx5_get_rx_queue_offloads() in order to fully comply.
>
> I leave it up to you, I don't mind if we include this patch only to revert
> it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP.
A new flag to keep CRC will be introduced.
We will need toggling anyway.
next prev parent reply other threads:[~2018-03-26 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 9:00 [dpdk-dev] [PATCH v1] net/mlx4: disable CRC stripping Ophir Munk
2018-03-19 16:36 ` [dpdk-dev] [PATCH v2] net/mlx4: support CRC strip toggling Ophir Munk
2018-03-23 14:53 ` Adrien Mazarguil
2018-03-25 16:17 ` Ophir Munk
2018-03-25 20:19 ` [dpdk-dev] [PATCH v3] " Ophir Munk
2018-03-26 9:34 ` Adrien Mazarguil
2018-04-10 6:26 ` Shahaf Shuler
2018-03-26 11:38 ` Ferruh Yigit
2018-03-26 11:54 ` Adrien Mazarguil
2018-03-26 12:30 ` Thomas Monjalon [this message]
2018-03-28 6:03 ` Shahaf Shuler
2018-03-28 14:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2388926.RzC4zprzFL@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).