From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 520DD2BA1 for ; Tue, 4 Oct 2016 11:31:04 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id f193so23307655wmg.0 for ; Tue, 04 Oct 2016 02:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=1my5K2g4ZhgS75gxQFNJlVabBLDafYWB6sKERgF0lLg=; b=HEomWTBPI9Fv5C9N+3qc+u/QbE4d9ylRAtPYnpDrOeKgCxcmtS0Bp7F4AvwdKK1Ecb ATIUeocoqnHVl52VIYVk/0SupqBZaUZAoVkcSZDpXaiTe2uph+/GJMYgaTHQ+GllM/+c 0l5J1tRQqSQKQ/2qyRzuJ6sxEh7baaMM7McCc1oRPv+HwT6j9CpJ4BpIWjJpIbXe+RMa gKVyoqnyLBW+ZtjEFd1VvLQ635IzJh6ikhAImRHPsjYhks7ysBvEDUOxfXAcuHQ5HLf+ U2pFQ19klX5rE+KTrTj5bpbi1sYPtqSnaPbaCM9xFCjBDFGOEpCjxVlNATH0SkHIvqW7 RaXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=1my5K2g4ZhgS75gxQFNJlVabBLDafYWB6sKERgF0lLg=; b=V3f2il8AGFyBZK7sctFw6p13N6N6Uj5vZZWufplNZYmKgRaq3uuYZXdZHb/JQX9WZF ViXaLxSJWF6x7J+Zrm/XZS1SATIIYrNPzp3/c3gNH69IoqzXcFRRZBrl4VD4XXMiUe5r b6UeoDlrFyfws+9ZPEg6EmGybNvkBLlwmmw2Wymd6vNi132lCMKUHE5BTZ8eQWs2Ifq6 OrK9h8vbbC2V4iKLjNjqvkuG4ivFtigaNifQMTZdtPRXgqH2a5IgYWcUSMD3/0x1Ussd FmdZWzAhpxs5CKq6la7c3ucNrAMOcaCRGSPMrRM69j9l8yh5JC7g4YaPjjNfKOdAKd4C WxaA== X-Gm-Message-State: AA6/9Rnziot1hrOvBpQQJFwaUzh9oXt5njqHDFPqtKsg3OvSukhxUOF7MpQeDB0X9P+Y93Wb X-Received: by 10.194.123.197 with SMTP id mc5mr1412648wjb.231.1475573464070; Tue, 04 Oct 2016 02:31:04 -0700 (PDT) Received: from xps13.localnet (172.17.90.92.rev.sfr.net. [92.90.17.172]) by smtp.gmail.com with ESMTPSA id qo8sm2492093wjc.46.2016.10.04.02.31.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2016 02:31:03 -0700 (PDT) From: Thomas Monjalon To: jean.tourrilhes@hpe.com Cc: Sergio Gonzalez Monroy , dev@dpdk.org Date: Tue, 04 Oct 2016 11:31:01 +0200 Message-ID: <2392264.CCbfKQ6uGK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <417ffa55-a8bf-a769-d751-b023d72993d8@intel.com> References: <20160921211049.GA27472@labs.hpe.com> <6928094.Vgjcapsp68@xps13> <417ffa55-a8bf-a769-d751-b023d72993d8@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1 v2] eal: Fix misleading error messages, errno can't be trusted. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 09:31:04 -0000 2016-10-04 09:03, Sergio Gonzalez Monroy: > On 03/10/2016 21:46, Thomas Monjalon wrote: > > 2016-10-03 08:55, Jean Tourrilhes: > >> On Mon, Oct 03, 2016 at 02:25:40PM +0100, Sergio Gonzalez Monroy wrote: > >>> Hi Jean, > >>> > >>> There are some format issues with the patch: > >>> > >>> You can run scripts/check-git-log.sh to check them: > >>> Wrong headline format: > >>> eal: Fix misleading error messages, errno can't be trusted. > >>> Wrong headline uppercase: > >>> eal: Fix misleading error messages, errno can't be trusted. > >>> Missing 'Fixes' tag: > >>> eal: Fix misleading error messages, errno can't be trusted. > >>> > >>> The script's output highlights the different issues. > >> SOrry about that, I casually read the page on > >> http://dpdk.org/dev, but obviously I need to look at it again. > > No problem. This guide is more oriented towards regular contributors. > > You come with a bug and its fix, we can make some effort to format > > the patch :) > > > > The title could be "mem: fix hugepage mapping error messages" [...] > > Sergio, do you have more comments? > > Nop. > > > Should we wait another version or is it OK? > > Maybe you'd prefer to rework it yourself? > > AFAICS it really is just the commit message formatting, so maybe you can > fix that when applying it? Yes but I've just noticed that the Signed-off-by line is missing. Please Jean, could you add this required line with your explanations, rebase on fresh head and resend please?