From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F00DA04B1; Wed, 4 Nov 2020 17:51:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F7042C27; Wed, 4 Nov 2020 17:51:41 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id EEF2B2C16 for ; Wed, 4 Nov 2020 17:51:39 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 4D2FB580134; Wed, 4 Nov 2020 11:51:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 04 Nov 2020 11:51:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= mNrKOTj8B6+CC8qYi/wgX6ZX6vt/KQxP2hn5Z6m5GrU=; b=lqD4WlBFFxuU6sn4 vg5/cIJbr/qmjzXdTLksFHJiOn4K9PUdKmVQQ/XJyIB5utXjdRixiOi9ofkqxTPl HQYgXlNLP0EPS/OVaJJKDsMmqHacRVcEhYuF/XMuVHEnMX947mxUNwMxMr+sNih4 5n8mO+Ft0R6/8kpPq45qgS7Pgsbf/c1PDArzQa59UrbgewDDhkqcz8AH9YZxhJAU Il4TFCrnw+py75ZQF4UqFdJB6hoR5IhNdXPBFSgDvMqWJLgUBB5sZrDCvHHdB+BU wmHSSo5tTwDCCqN6cRRsuh7cGY5lraIGV8KuvSuxJUGXnsjx/wPSqUliaUIsv/Hm J+K5pw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mNrKOTj8B6+CC8qYi/wgX6ZX6vt/KQxP2hn5Z6m5G rU=; b=dKnCvGxTKa/72uA9Nc5Fg7pjC4zENbI59zU8Y0OBnL+X1P4u3NzaKLU7W XfJH9tIIRNGcb01QhZ2pboiVXCB6QJGfLhj0UUhWnxqfH1A0iXq7Ih+XvxGNC1yJ 0TfLrs+ZXe/4fy1CwNMhL0ge1E+/9yCbzt9uqu+K3yx4LsScA+eO8+8aTXqsx2ZK p4KsrPbSYPIE8efG+wqNSLehxVk1qBxLxdCeHkGfqzh94pTGw9HGQmxhSDKD+NTS PNeeU5HZ5tawCngmDm6A9QfBe1dltMFMHlfx1cf0jBLqX+EBmmlNAFBG1kcfs80U Ars2FuBknaI2EIjDCtqpVVo5GWaxg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddthedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4246C3280390; Wed, 4 Nov 2020 11:51:35 -0500 (EST) From: Thomas Monjalon To: SteveX Yang , Ferruh Yigit Cc: dev@dpdk.org, konstantin.ananyev@intel.com, beilei.xing@intel.com, wenzhuo.lu@intel.com, bernard.iremonger@intel.com, qiming.yang@intel.com, mdr@ashroe.eu, nhorman@tuxdriver.com, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru Date: Wed, 04 Nov 2020 17:51:34 +0100 Message-ID: <2392354.O08QGPWUWg@thomas> In-Reply-To: <5676659a-980c-7f13-caa9-d83a5f89c700@intel.com> References: <20201028030334.30300-1-stevex.yang@intel.com> <13f49ee0-8cee-5f1b-e3bb-0d3a54e9e189@intel.com> <5676659a-980c-7f13-caa9-d83a5f89c700@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2020 14:29, Ferruh Yigit: > On 11/2/2020 11:48 AM, Ferruh Yigit wrote: > > On 11/2/2020 8:52 AM, SteveX Yang wrote: > >> When the max rx packet length is smaller than the sum of mtu size and > >> ether overhead size, it should be enlarged, otherwise the VLAN packets > >> will be dropped. > >> > >> Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") > >> > >> Signed-off-by: SteveX Yang > > > > Reviewed-by: Ferruh Yigit > > Applied to dpdk-next-net/main, thanks. > > only 1/2 applied since discussion is going on for 2/2. I'm not sure this testpmd change is good. Reminder: testpmd is for testing the PMDs. Don't we want to see VLAN packets dropped in the case described above?