From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0054.outbound.protection.outlook.com [104.47.41.54]) by dpdk.org (Postfix) with ESMTP id 988DB1AEF5 for ; Tue, 19 Sep 2017 15:03:34 +0200 (CEST) Received: from BN6PR03CA0073.namprd03.prod.outlook.com (10.164.122.139) by MWHPR03MB2702.namprd03.prod.outlook.com (10.168.207.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 13:03:33 +0000 Received: from BY2FFO11FD021.protection.gbl (2a01:111:f400:7c0c::190) by BN6PR03CA0073.outlook.office365.com (2603:10b6:405:6f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.56.11 via Frontend Transport; Tue, 19 Sep 2017 13:03:32 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD021.mail.protection.outlook.com (10.1.15.210) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.35.14 via Frontend Transport; Tue, 19 Sep 2017 13:03:32 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8JD3Tm3005900; Tue, 19 Sep 2017 06:03:30 -0700 To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-3-shreyansh.jain@nxp.com> From: Shreyansh Jain Message-ID: <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com> Date: Tue, 19 Sep 2017 18:44:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131502998128023829; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(376002)(346002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(24454002)(199003)(189002)(377454003)(6246003)(189998001)(31686004)(230700001)(33646002)(105606002)(2950100002)(6916009)(6666003)(106466001)(54906002)(104016004)(53936002)(50466002)(2906002)(54356999)(50986999)(305945005)(83506001)(36756003)(76176999)(81166006)(5660300001)(93886005)(356003)(85426001)(8936002)(64126003)(97736004)(65806001)(77096006)(65956001)(53546010)(498600001)(8656003)(4326008)(47776003)(31696002)(81156014)(58126008)(229853002)(86362001)(8676002)(65826007)(316002)(68736007)(23676002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2702; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD021; 1:fkv8mml3wwFCF0VuQ9vM7ZnD1Rw/8W+QZ4XLshLM7LwpuTfyd2nfYwCG2WFuc2Lhr2yczeKPnzhr5RohDnwhELKON3Z9IJz+dxKPpJsaXQdkVzttChb8w/A2hm6rBZpo X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 652cd7c7-220d-43ba-77b5-08d4ff5ed4c6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:MWHPR03MB2702; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 3:QhojKGMKF2OPWCLZKQ1gD37kvygn/5MFcv7DL5X7hltfcAfbFaun6Hpq2gboDRSINNd1tm32itcd9HhYt15LxQCUNOLKYIw2sNpgn9j4aQ8sk9HeQhbyQh5C2nyDtfs3pcmG8ery3/BLueA20omZwfRwG86+PQh+tfJKWHCWaiPgKCGlXsmD3dS9eFj8IBigzDYYebXOe+T5MnwY/f57OjWFleljhjhYTxAHwCp2ZsqtUnsdFSdoBy1Igl6UG8Wa0gXtFopo8P6RjkuSbyS08pe1YXCXUniV3wQqTjRDgOwbrYgwL52JtDEYHVymLTVqBBNbVoqYEkj5LpnERIhkIKJr8TLW6qmzNvvDtbkXd4g=; 25:PWNhH774t32TPDJgLbAiBSrUZIyuc8err43TgLaweNh3IgDbzog8xmW65WrP/QTMrNZEmBmWAt2ghPjOop3p/EW79fqGMQBMF+Nr/puapJNjN+1WP6Q6KcW0LgqK8EnT6E9dKeAEV8oL8Y/WXez5LoX6ZjUI1xZ5mfaSQDuWn7z215jc0M7O/iNpdJrWzwDmsiyRuKqsq2abw5ggX+gvrHpGOzVwsOpdCJ0WdKrgJA1ZiTELfNgmy1twZdU8sknPkrLAkBQoGNV9iDECm0TcaI4lMy2sVGywP1tK4hpNGaD0mfaO8+XtQEtbYXudd5lNinyEuZBh7Db7pwwbPScsxQ== X-MS-TrafficTypeDiagnostic: MWHPR03MB2702: X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 31:TTdEhBjswd+iZDHfZiS7x5g6xMUKQEQpMjF1yoX7UIQ866ToisfcHYc9aBJzbhEcFatQC/T7dm/knjy3ySvt3c48pKSNJGKl6JPtXTFyCiwwee3LuC45ZdW5IgbmPpu628X4h+/T8I6vuW2/BEsrJqEsnfI6sT6PSYU49XwgVXSmcfnUhvMGG9fdz9ACb8iXwr+D28xA+yUjMKlBrir7NFJOSADpE+TQCaEIQBLRsYw=; 4:0qBpdVEeh9IlUoGE/XMndxPSQvNvV9fITa5PBkS2Q24/sexGUicgYnxcvELbRrXOdqrtiF6otn9bR1848RLcX9AKpmgWKOkorWSb2icLmirVNOi6hCmjR/XeOBRNz0oQHh3f90VoFPaEY9EZO74FWvMQk5FcF7hOImXsnoy1OMn5lqy3NcqNX+e3iSKFlnew6GGk9jfZqO33N8BlLqDn+IFzYK8ViIqOSpqIU7sNkMz+8sKe5qnQhNYOn2Hl8eSGXV9AYSTQSI1p1IlVdFhmGdWefGC24mB+OU0FLzVRHMtCYJPZlnuP6ebGFU+w3t7c1DkJ/IzXC/l5ReMpdiBgfw== X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123556025)(20161123559100)(20161123565025)(20161123563025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2702; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2702; X-Forefront-PRVS: 04359FAD81 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAzTUIyNzAyOzIzOnZFeXhwZ25ienc1NHR3WVZidXZteXp3RW0y?= =?utf-8?B?ejEvZ1dVdUtOZ285am9SUndpR1FkNjlSVzQ0RFhyVnJ2VDdCc0ExUlhNT3M0?= =?utf-8?B?SDJoM29QUExDOWVlUUhLVUQ4WlJGYmk2aEZxVXAwRld0cWloTmlCakQ4QUY4?= =?utf-8?B?VVFyZ05udm95bnV5UEFiQUJ6a2JmRjFraHlTdTFWemROVW9pOUFyRjN3d1Za?= =?utf-8?B?bnMvSVo4UFRONi9idVI2c2RTSC9reEhia3Avak8zbmlnQnZtdzZZT09xbHdy?= =?utf-8?B?VGZjbER0emFST3JUOGhwTWpWNEdnN3QwVm5ORUUrRFFqV04rV0d6dXcybHd5?= =?utf-8?B?ZUlTSjJrNlllRE1OVU1LblgrSzRYZ0l3UHdGRUhDZlZMM1NKL3VRNVkvN3I2?= =?utf-8?B?eCt4UDFQbXFpeTMrQnY0NXNuVjMraXhhSnhZNStVNUVodElpU1h6Yk94WUNM?= =?utf-8?B?eE9pOGM0L0VHUUZQcTlxWDVEd0dwNFVhK1JhWTQzOWhsdXNOdkZna2FmdEpm?= =?utf-8?B?aWppWCt3QkRtVFpzYlJNY1A1ZnVRdUZlSmxRZU5oSzB2aERBbDVPS1g1aURU?= =?utf-8?B?OUZrMHhGbWVRZy92bzd5OFVYMjdoZ3BrdUozcnNVaUNDRGJXWE9FNnBQZjhG?= =?utf-8?B?N0E1aGtMY05pYmVRRVJoQ3IyYXFydVloY3VWRTNGTkZMZm5KYlorUEZpanNv?= =?utf-8?B?RHR0SlFZTzk0RkhjbFpTeS93UlMvSlY0ZTZGQUovN1ZDM21OSjJVVTQyWURz?= =?utf-8?B?R3dJWXpTWUVXaWxuamJhbDFjb3grYktvMnVEVUNhQ0VWNXpuS0o2QmtubkEv?= =?utf-8?B?cml5aCtySE9veFlDRGkwdWFobktEaUw0OWtlSFUyTGJ4VTFmcXZaOWlWbitz?= =?utf-8?B?WUFYMlBCVWFSc3o2anVLZXZoNS9DL1ZKbFk2aWNQY3J2bWRXWkdqb0ZUZFN3?= =?utf-8?B?TTUxYldiRmVYSkQ1U253Q1hKQUVvUnBvYnVPbnRjVVRGaUpPZHI4ODh6eFNG?= =?utf-8?B?dERFMWw4b05SMWN1VTNmcHkycm5ucVYvajIyOFdJRnBtR2FVTWFoYXVoTGFp?= =?utf-8?B?TmJ5cktxQUYrdmlZcW5uZnJZcEtTTWZUMXZtYzJFaGhZQzFkbWkyQTVoSFpa?= =?utf-8?B?TkNUTk1uZXcyOUR3TzBrNExhUWlITndNMThYNWJPZThNaFY2M0NiVis3Vy8r?= =?utf-8?B?VzN5aVp2aVRVaFhwejZiQVYrYklVNmhoSWo3YWlhV1gxVHNMLzF1NU1uVVUv?= =?utf-8?B?bGk1MVkwcG05aFVXejdnU3c1TndhRStCMkl6VTNPZHV5K0QxWXBvekkrSHVO?= =?utf-8?B?NmlMa3J2d0hLTGZyZU5HVTk2OGNESFk0MTFOdUNhQVhtK3hJUFVJVUhTUkRO?= =?utf-8?B?MUNMeG9rbkRuRDN5R01LTnh2UnRRU00rUGc3VGZ6eHd3MGc5ckpWYjBYRHZZ?= =?utf-8?B?eUIzRVFLUDg0b201TnZPU2RXdzJRL3RpajI5bkt4YThIYld1VUlScDFEaUhT?= =?utf-8?B?Y29Hc0J1ZTJtbk45WnNmOGVqMExFcFh2ZC9RdnJRU1dzM2hPMDBiZG13YzdS?= =?utf-8?B?cjBybm5SajN5UTk4UDhreGZ3NXJKUVltT2pibWdWNGlmUjNONlEveHlVNEZ2?= =?utf-8?B?a01pS1VtQ1NrSEx1Z3JNN0FYMnRld2RIdmdhVzVubitVQ0s2SVdqeityTjFW?= =?utf-8?B?emFMeklFeTlMMWcrN3poSENJYld2NFc4ZWVEQ0pCNnlqc3ZGUTVkdEpzb3RJ?= =?utf-8?B?OXFRSExZdUVaZFlXKy81cGd5VGxsY0l4SjZjRGxhU1B6aDVBRWhxQ1pnWU1M?= =?utf-8?B?Y0Z2L1VrS0owSXVoL1EyRWpmdFlDdzBCVUVFbFlWWDQzZ0YxdzVFaHMyNCtp?= =?utf-8?B?WWowTFl2QUhZTHVyWUZWL3BWMk1Fak5PemF2MzkrR09TY3FPSnYwVkI1WHJL?= =?utf-8?B?eDBHdUIwakNBenpLMEpaVnpzcDdrNW9EL0JsM1RybkxkV3IzenZhQy9Xb1Jr?= =?utf-8?Q?Wmw4ak?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 6:TWpGydrvvknt4/ruNjg5Xrpz30DnhL8YYnkVMzMGTNaeEFhCalkW6bSvPll4gtSBdkH49/yYhGSeYJcKjRrlVdlCKL88RgNB2xyzzYc9WA40VBIQFDKRterVCsL92k15E1azuaZ2x7UjsBy5dPeJLOSblmcxjrHFT5zEtfEhMPUzJBIRFnCC2RafdWuWhcZRsMkqWFgBhHXlwfhzRqkgSdoBhaziqblCwSJjV8mF4Gd/ltki/afYEfXSU33nm8QxYZGP8d739mCSeX2XE+ixS88pEDwcKOJJIw2v6WPhMPdH8Ey2D3Q1WyCgTKNbvcQt7qiJPqQFC0XfyMViX/PveA==; 5:iJhQPxB+R1d4wulnDsNF7Ha1Rfh5wM7rQQ0JhHQbVzX0t5K9lnsx85XtUhdZ+d1t5Bcrh1GJHFqfmqvv7X6MsSPAkNPUck6bgA0lhW8kjnY5yBXxUxFR1vxRSfntEHC6bFYOUyWYx2QEWO39H/SFOA==; 24:mo4QsLd6qVw0QhYGwE15Y4Cv6gcxdgHHsRwTfAaG8Pgc2VRQhTeaBS6w4hz5jgcIujzrFLkB+JjOpbpKNZYioRsIMUbysMcemIEhXO3rt9w=; 7:X4OiUlZNeYaTRFCjh6GOTDD0ewY9dPd11CkYZRzYO2Smz7cV8Rtz/c4X2EToK1uW1Bi8oE4j8XrVuap4pSElnfHPB7pZuhCs7/ahUOHVTC2EhE2fgf/4LtwhgoNsgTvcYwKruqyO/G0V+280V//drWKXu1xYHu1eJJDuALs5hgzQGnZN33tGZip/rLLspMqzXdlflKxi4IrFWJPwyGp+1DYlv51Zxz4qxRWCkebGXCs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 13:03:32.5839 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2702 Subject: Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 13:03:35 -0000 Hello Ferruh, On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: > On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >> Signed-off-by: Shreyansh Jain >> Signed-off-by: Hemant Agrawal > > <...> > >> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map >> new file mode 100644 >> index 0000000..d97a009 >> --- /dev/null >> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map >> @@ -0,0 +1,7 @@ >> +DPDK_17.11 { >> + global: >> + >> + rte_dpaa_driver_register; >> + rte_dpaa_driver_unregister; > > "local *;" ? Agree. I will change this. Currently rte_dpaa_driver_* functions are being used locally within bus/dpaa. > > <...> > >> +struct rte_dpaa_device { >> + TAILQ_ENTRY(rte_dpaa_device) next; >> + struct rte_device device; >> + union { >> + struct rte_eth_dev *eth_dev; >> + struct rte_cryptodev *crypto_dev; >> + }; > > Bus struct should be independt from functionality, this has been done in > PCI, can same thing be done for dpaa bus too? Sorry, I didn't get your point. This is the rte_dpaa_bus structure: struct rte_dpaa_bus { struct rte_bus bus; struct rte_dpaa_device_list device_list; struct rte_dpaa_driver_list driver_list; int device_count; }; If you are referring to unlinking eth/crypto functionality from rte_dpaa_device - that is something which needs investigation. I have seen patches on PCI from Gaetan. Can that be an incremental change over this? > > <...> > >> + * @return >> + * 0 in case of success, error otherwise >> + */ >> +int rte_dpaa_portal_init(void *arg); > > Definition is not in this patch. > >> + >> +/** >> + * Cleanup a DPAA Portal >> + */ >> +void dpaa_portal_finish(void *arg); > > Definition is not in this patch. > > <...> > Yes, this is my mistake. I will fix this.