From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FA4B43294; Sun, 5 Nov 2023 19:49:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD33A4029E; Sun, 5 Nov 2023 19:49:52 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id AEF4E40278 for ; Sun, 5 Nov 2023 19:49:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1BC495C0114; Sun, 5 Nov 2023 13:49:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 Nov 2023 13:49:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699210189; x=1699296589; bh=EUwMtaTgBxRp+bhN1ZK99n5r7bfsdqFhzZK kZ4tat4c=; b=RhlpAiiMxW4MLVtVvKjJfJom+KDz3ThKX6kWc9dFdMpFma6WNBe 7+maO1+Mc2WcgqiwJiu2bw0zutres0bhvsFbXvHqhvhuMlDNMpYeM6PdLd9Eq/RG sREpgG5iUcd1mA1zxn3nMMyRUJ6Upgp/LMtiABmgskm1FCDq9FfkJb+4u5eZQC09 a5X5IXTccDR4ljzm02VxbEZrHm4+xJ/plLF2Dr6XCju0wh9FFo9Rdw5SOExz8H6h FarlJOpbvCAoq1N/mN6AzLtP1sXvxXJQBhJa2+OW1MukuUg32ZLkCBt9VuY/mgFx 7BhINJs1s4VBemxREnkTa4Wl7xEGQhswJaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699210189; x=1699296589; bh=EUwMtaTgBxRp+bhN1ZK99n5r7bfsdqFhzZK kZ4tat4c=; b=iodSTC73r+NqY9jXMSkKBy5VcDDbFZPYqz/GDVIm+luE6dCGZXP DbvtLPyO8rh++GoR2OkWJ0s+quT17ggWfTfDdRHvlpeHFdLep2b3fVQ+KWzT2Jom ZgJwDU5AIlUZhKHr17sl1bF0jWWDEkIN1x8p4gCI6f2lNiygQKso4VLonapBzlJK y6QMGEYZzqLBvq83lnSQRrE9BAQM44Bn15K4zo5lzlM7nHOwO8KPTPz7GctPq9/C sg0Cpie9K3lMOpDRKkCJXPQJTlJvkaHWo5UDjwxie0TzMhBK0BC/uXRis6jJHRn9 Wr1il+Vxdbqq7bHPY8KPoQaZKZY80VCiabw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudduvddguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Nov 2023 13:49:47 -0500 (EST) From: Thomas Monjalon To: getelson@nvidia.com, rasland@nvidia.com Cc: dev@dpdk.org, mkashani@nvidia.com, Ori Kam , Matan Azrad , Viacheslav Ovsiienko , Suanming Mou , Gregory Etelson , asafp@nvidia.com Subject: Re: [PATCH 01/30] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data Date: Sun, 05 Nov 2023 19:49:41 +0100 Message-ID: <23934115.ouqheUzb2q@thomas> In-Reply-To: <20231029163202.216450-1-getelson@nvidia.com> References: <20231029163202.216450-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The description of this patch does not match the change. Also the change is going backward, using deprecated fields. It does not make sense, I'll skip it. 29/10/2023 17:31, Gregory Etelson: > New mlx5dr_context member replaces mlx5dr_cmd_query_caps. > Capabilities structure is a member of mlx5dr_context. > > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam > --- > drivers/net/mlx5/hws/mlx5dr_definer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c > index 95b5d4b70e..75ba46b966 100644 > --- a/drivers/net/mlx5/hws/mlx5dr_definer.c > +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c > @@ -1092,7 +1092,7 @@ mlx5dr_definer_conv_item_gtp(struct mlx5dr_definer_conv_data *cd, > return rte_errno; > } > > - if (m->hdr.teid) { > + if (m->teid) { > if (!(caps->flex_protocols & MLX5_HCA_FLEX_GTPU_TEID_ENABLED)) { > rte_errno = ENOTSUP; > return rte_errno; > @@ -1118,7 +1118,7 @@ mlx5dr_definer_conv_item_gtp(struct mlx5dr_definer_conv_data *cd, > } > > > - if (m->hdr.msg_type) { > + if (m->msg_type) { > if (!(caps->flex_protocols & MLX5_HCA_FLEX_GTPU_DW_0_ENABLED)) { > rte_errno = ENOTSUP; > return rte_errno; >