From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BC57A04DC; Mon, 19 Oct 2020 22:27:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C2FF9AEB; Mon, 19 Oct 2020 22:27:09 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 33D585AB9 for ; Mon, 19 Oct 2020 22:27:07 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A59535C01D6; Mon, 19 Oct 2020 16:27:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 16:27:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= tt6WKkAEdtAJiFoz44Rrd9wdJmrpxphaBUnhP7O3gsA=; b=cqnXvU0ddTXKitp2 0msh4GhPn8drgBDFDiumF0JVf54vYBxtelJ3m8cO/iS4XKH9xw7bHaDUGKtgUdnt wAz/d+SQy+OxSDuX0jvTa1NdJbcvn/vKcCAMUgv48BBu3zCfheONxqiMQfGJdq+a h67LyZjnSfJKt8r1yDgoI62k+nl5yQ1vwm9TiJUuKSFxDt0I5TaccwfrZQhey1qT J2kVZ3UDr7dgI4Pj4JgwPh6oB/z5WhqBC5G1DB5DEcxFhCARKIjDE8eBLfUh+LYO moLrzR3oJoB/0qcwRMhs3I2ctMZQc2RsfPnqbr+OOC+NT9VFZJigCP9K0v+byeCq XNELoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=tt6WKkAEdtAJiFoz44Rrd9wdJmrpxphaBUnhP7O3g sA=; b=lTzfAJ2VXZEmJmT7RxF/DVvtTYCCv5b2hsOXArzkA18O12cwMPmvIVxQk PhEVbeIa0IN7hQYHBpqtbSWoWf5j9jqyFZCgqXnGJ7J3MJtRmtLO1eVmIdxru8wo fDwfjdEYDWkxKOIZQJMx5KPsA6xH4Tdx56Hc07LsKfbB54GYVzCw5hMtdPLFcgyw hq0Gb6AiiDqFWdCal6Juw+GRULk6UgMl8wBflvumN1FFW5+FLktD610ptCqoAs/2 wPwCw1J12LVfzsc8SGS4Llmh2n7HQHun7U7ZXLOMOvG1wCFYtye+o8QjJnqb283K hQsAFW+3brTcNSAO2GKxA4i5sptrQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedvgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 143B1328005D; Mon, 19 Oct 2020 16:27:03 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, bluca@debian.org Date: Mon, 19 Oct 2020 22:27:02 +0200 Message-ID: <2393931.9fLth6X2y1@thomas> In-Reply-To: <20201015150554.950838-1-bruce.richardson@intel.com> References: <20200916164429.244847-1-bruce.richardson@intel.com> <20201015150554.950838-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/8] Rework build macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/10/2020 17:05, Bruce Richardson: > Following on from discussion in RFC v1 and v2 of this set, this version > reworks the automated macros defined by meson to indicate if a > particular library or driver is enabled in the build. However, while it > does so, it also maintains compatibility with previous releases to ease the > transition for any apps using the older macros, which already has to > contend with a change in DPDK build-system and to switch over to picking up > the library names from pkg-config. > > Advantages of this rework: > * Much cleaner having standard macros > * No need for defining the format of macros for each class > * Shorter macros (for the most part) > > Disadvantages: > * Potentially requires application changes > * Inconsistency between the auto-defined macros and the other feature-set > ones. > > Bruce Richardson (8): > app: fix missing dependencies > examples/l2fwd-crypto: fix missing dependency > build: add defines for compatibility with make build > qat: build from common folder > build: remove library name from version map filename > devtools/test-null: load all drivers from directory > build: standardize component names and defines > build: replace use of old build macros Applied, thanks