From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E01111B7E7
 for <dev@dpdk.org>; Thu, 10 Jan 2019 18:40:17 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 582B021EF8;
 Thu, 10 Jan 2019 12:40:17 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 10 Jan 2019 12:40:17 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=tg4oEc2zaV3ygBsDTOxmpnDY7YOwBiWAAkSL0t62fT4=; b=YP5kl4lod5Lg
 Rk1n+U965jv5ls5IRmfAfwCFXhuz6LfPgCyyM5sEzXou2tXC7dwilTIoX6U/gRRC
 5UDIeV/uz8ahdxa3f/1MV3fKHVNLqbzQikCXDrFDqAJXTjl5y/A5ooUE1DMCKGOB
 A4GyS+XIeOgS4GhwvWSDCSVKSl4R2YY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=tg4oEc2zaV3ygBsDTOxmpnDY7YOwBiWAAkSL0t62f
 T4=; b=yIUIvRRIEBfnsotUbfUNPH03LpQavMQsdFWXKDfviq45Ec17tWVTkOHuY
 fE5csdrQQLMFg+lZcE/nl1BMr1nQM+pwQUGHsUhf8Rz1vrOA+ibrZzJKkHWv2RxP
 Fhpi60Wf/ktcS3PCpwmD8NbBW4mCjrsO59TOGu0q/WAKsFZ21P3dzoDUVrKkxcTQ
 EfbZ1SzHIhOaKVXUXV7gvWJ2LGu3tmOdCjLiQ6EF5u+fZb8w/sFI3rN/1nXc0avF
 BLydTMDvUiWei/s8uZ1CeKxPfxjMGHhq4v6sChpdVA2wRs9k2P5S0DZ+wZ5VbEEz
 m05VovTw48HMBqXfQrJat6vMIG2xg==
X-ME-Sender: <xms:gIM3XDZ_Y7Wo89u62NhW5xjvd3cs2N0XJHx42iBIMTLceZIMkWc3dw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfeefgddutdehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef
 tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg
 hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu
 oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd
 efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:gIM3XJmNKoqkCTju910AQHEZthtRf-8Xr7n96iSaxHHJDTaLq5Ds-w>
 <xmx:gIM3XIPDkzHnn61fn6yL14PUnICNjvZK8CQij10jYKYuQmS2NESPww>
 <xmx:gIM3XCdJPP1d9Qork-RWVEgkZ3JcEMlcVtwVwyCuWH5Qc3lpK6k6WQ>
 <xmx:gYM3XHbICn-K5Zxx4F-btLAAizj6wENmnrAhTDdWSZ50KqKrk4z9Rg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 65A42E4662;
 Thu, 10 Jan 2019 12:40:15 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, konstantin.ananyev@intel.com,
 stephen@networkplumber.org, reshma.pattan@intel.com, jasvinder.singh@intel.com,
 stephen1.byrne@intel.com, amol.patel@intel.com
Date: Thu, 10 Jan 2019 18:40:13 +0100
Message-ID: <2395887.NJRNHdBidz@xps>
In-Reply-To: <20190110213645.29901-2-vipin.varghese@intel.com>
References: <20190107153829.34047-2-vipin.varghese@intel.com>
 <20190110213645.29901-1-vipin.varghese@intel.com>
 <20190110213645.29901-2-vipin.varghese@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v9 1/6] app/procinfo: add support for show
	port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 17:40:18 -0000

10/01/2019 22:36, Vipin Varghese:
> Function show_port is used for displaying the port PMD information under
> primary process. The information shows basic, per queue and security.
> Also helper MACRO 'MAX_STRING_LEN, STATS_BDR_FMT and STATS_BDR_STR' and
> meson build file is updated for new functionality.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Acked-by: Reshma  Pattan <reshma.pattan@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---
>  app/proc-info/main.c           | 119 ++++++++++++++++++++++++++++++++-
>  app/proc-info/meson.build      |   2 +-
>  doc/guides/tools/proc_info.rst |   9 ++-
>  3 files changed, 126 insertions(+), 4 deletions(-)
> 
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index c20effa4f..2108c24b0 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -29,6 +29,9 @@
>  #include <rte_branch_prediction.h>
>  #include <rte_string_fns.h>
>  #include <rte_metrics.h>
> +#include <rte_cycles.h>
> +#include <rte_security.h>
> +#include <rte_cryptodev.h>

Is the crypto include really required in this patch?