From: Thomas Monjalon <thomas@monjalon.net>
To: Eli Britstein <elibr@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad <matan@nvidia.com>,
Asaf Penso <asafp@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
bruce.richardson@intel.com, konstantin.ananyev@intel.com,
olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH V2 3/3] eal/x86: avoid cast-align warning in x86 memcpy functions
Date: Mon, 25 Oct 2021 17:29:05 +0200 [thread overview]
Message-ID: <2396188.RVIeCzPhhI@thomas> (raw)
In-Reply-To: <20211021085132.12672-3-elibr@nvidia.com>
21/10/2021 10:51, Eli Britstein:
> Functions and macros in x86 rte_memcpy.h may cause cast-align warnings,
> when using strict cast align flag with supporting gcc:
> gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
> CFLAGS="-Wcast-align=strict" make V=1 -C examples/l2fwd clean static
>
> For example:
> In file included from main.c:24:
> /dpdk/build/include/rte_memcpy.h: In function 'rte_mov16':
> /dpdk/build/include/rte_memcpy.h:306:25: warning: cast increases
> required alignment of target type [-Wcast-align]
> 306 | xmm0 = _mm_loadu_si128((const __m128i *)src);
> | ^
>
> As the code assumes correct alignment, add first a (void *) or (const
> void *) castings, to avoid the warnings.
>
> Fixes: 9484092baad3 ("eal/x86: optimize memcpy for AVX512 platforms")
> Cc: stable@dpdk.org
>
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Series applied, thanks.
next prev parent reply other threads:[~2021-10-25 15:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 6:49 [dpdk-dev] [PATCH 0/3] Avoid cast-align warnings Eli Britstein
2021-07-13 6:49 ` [dpdk-dev] [PATCH 1/3] net: avoid cast-align warning in VLAN insert function Eli Britstein
2021-07-30 10:57 ` Olivier Matz
2021-07-13 6:49 ` [dpdk-dev] [PATCH 2/3] mbuf: avoid cast-align warning in pktmbuf mtod offset macro Eli Britstein
2021-07-13 7:43 ` Thomas Monjalon
2021-07-28 15:28 ` Olivier Matz
2021-07-29 7:13 ` Eli Britstein
2021-07-30 11:10 ` Olivier Matz
2021-08-01 8:06 ` Eli Britstein
2021-10-19 6:41 ` Eli Britstein
2021-10-19 9:47 ` Olivier Matz
2021-07-13 6:49 ` [dpdk-dev] [PATCH 3/3] eal/x86: avoid cast-align warning in x86 memcpy functions Eli Britstein
2021-10-21 8:51 ` [dpdk-dev] [PATCH V2 1/3] net: avoid cast-align warning in VLAN insert function Eli Britstein
2021-10-21 8:51 ` [dpdk-dev] [PATCH V2 2/3] mbuf: avoid cast-align warning in pktmbuf mtod offset macro Eli Britstein
2021-10-21 8:51 ` [dpdk-dev] [PATCH V2 3/3] eal/x86: avoid cast-align warning in x86 memcpy functions Eli Britstein
2021-10-25 15:29 ` Thomas Monjalon [this message]
2021-10-21 15:48 ` [dpdk-dev] [PATCH V2 1/3] net: avoid cast-align warning in VLAN insert function Stephen Hemminger
2021-10-21 16:16 ` Eli Britstein
2021-10-21 16:22 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2396188.RVIeCzPhhI@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=elibr@nvidia.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@nvidia.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).