From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57450A0487 for ; Tue, 30 Jul 2019 11:13:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C0901BFF4; Tue, 30 Jul 2019 11:13:46 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D713F1BFEC for ; Tue, 30 Jul 2019 11:13:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E6E920222; Tue, 30 Jul 2019 05:13:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Jul 2019 05:13:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=GojYgcMCUCAzlbe7bX9ldQdnnMQK/QfN5/GPFlWUZxI=; b=Kat7PWtnlap0 IPCdNzi+lz6kDopfPequJlf4TjtKbricNac76atgStx8jjWEihnjA0xvyB7QN0Pf 74fUzvzedp/OkGd5/7lg5fzf6+QBLKYfVFe29oa0R3vAggQb++oYU2w4sDT/pmWY gCIU2a/NSs9b+irHKGMRHzR6OhL9rJQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=GojYgcMCUCAzlbe7bX9ldQdnnMQK/QfN5/GPFlWUZ xI=; b=j0cmR16j/6xe9d3pYeX3FXB2eq35FvAQhNNFjO0gLnktrL7HvJgJET65H D84sIhGouuWmEkFzbz7aCoj17w2e9njw61naZnEjcMXWzHE+TAGz0oILDeBnMrOd as7F8IWSBtz57+KbMTAws0EFd4E1mFxp3BAGra+MWZSRTdIqYrjCiUX6Ubgj0XBI ptKnJtrW4jKYgTgYhhgrDZH0kyfx+xvrGRkCr8a7w4k9h/i6heFUK9NAayaLd/Ps bpxVBsj7AAcj/O7AXe4r4Tt2ckyhtyl/9orsgtymOgNoDTqPjp0r+ybgO4kiki8w FFwnm1XmKTrgyEmJEoSinKKuxkQgg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleefgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DCA4280060; Tue, 30 Jul 2019 05:13:42 -0400 (EDT) From: Thomas Monjalon To: Harman Kalra Cc: dev@dpdk.org, John McNamara , Pablo de Lara , Bruce Richardson , Harry van Haaren , Xiaoyun Li , "barbette@kth.se" Date: Tue, 30 Jul 2019 11:13:41 +0200 Message-ID: <2399561.MWAbWnzOnL@xps> In-Reply-To: <1564472662-31089-1-git-send-email-hkalra@marvell.com> References: <5296418.QIOJa9lHfJ@xps> <1564472662-31089-1-git-send-email-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/rxtx_callbacks: fix HW timestamp enable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/07/2019 09:46, Harman Kalra: > Since all PMDs doesn't implement per queue offload capabilities but > supports RX timestamping and also since rx_offload_capa includes all > rx_queue_offload_capa's. Hence moving the logic to enable HW timestamp > via DEV_RX_OFFLOAD_TIMESTAMP flag before device configuration so that > this application can work with all PMDs. > > Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") > Cc: barbette@kth.se > > Signed-off-by: Harman Kalra > Reviewed-by: Jerin Jacob > --- > V2: > * More detailed commit message. Applied, thanks. Note: there is a discussion about dropping this example in next releases.