Re: [dpdk-dev] [PATCH v20 4/4] examples/l3fwd-power: enable PMD power mgmt

[Thomas Monjalon <thomas@monjalon.net>]

22/01/2021 18:12, Anatoly Burakov:
> From: Liang Ma <liang.j.ma@intel.com>
> 
> Add PMD power management feature support to l3fwd-power sample app.
> 
> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>
> ---
[...]
> +PMD Power Management Mode
> +-------------------------

There should be a blank line here.

> +There is also a traffic-aware operating mode that, instead of using explicit
> +power management, will use automatic PMD power management. This mode is limited
> +to one queue per core, and has three available power management schemes:
> +
> +* ``monitor`` - this will use ``rte_power_monitor()`` function to enter a
> +  power-optimized state (subject to platform support).
> +
> +* ``pause`` - this will use ``rte_power_pause()`` or ``rte_pause()`` to avoid
> +  busy looping when there is no traffic.
> +
> +* ``scale`` - this will use frequency scaling routines available in the
> +  ``librte_power`` library.

Better to use a definition list for such explanations:
https://docutils.sourceforge.io/docs/user/rst/quickref.html#definition-lists

I will update while merging.