From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D85636C9B for ; Wed, 1 Aug 2018 10:23:09 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 590E0400063; Wed, 1 Aug 2018 08:23:08 +0000 (UTC) Received: from [192.168.1.16] (85.187.13.33) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 1 Aug 2018 09:23:02 +0100 To: Bernard Iremonger , , , , References: <1533111199-4621-1-git-send-email-bernard.iremonger@intel.com> From: Andrew Rybchenko Message-ID: <239fdbf4-dd8f-97c7-58d6-dfaefb28fe3d@solarflare.com> Date: Wed, 1 Aug 2018 11:22:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1533111199-4621-1-git-send-email-bernard.iremonger@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.33] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24004.003 X-TM-AS-Result: No-0.460700-8.000000-10 X-TMASE-MatchedRID: ZrceL/U8jXQOwH4pD14DsPHkpkyUphL9LoYOuiLW+uUmyikZ3KFyU6ip 18v0DWYVX3E2fHKxS5Kbu+FyWYBKSk1+zyfzlN7ygxsfzkNRlfJq8/xv2Um1avoLR4+zsDTtCQv lWYtoEBGZ0BwPWO8swj64tZPgQ4jrBX0dJ4r+8l4ngLFP7JDUT+LKSdg00bhSwnkJdHfng2NiAB yU1U+JwyIWVLG977WGvjDNqsQ/AWV+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.460700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24004.003 X-MDID: 1533111789-ClF2b_JkRg0k Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set and clear keep CRC offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 08:23:10 -0000 On 01.08.2018 11:13, Bernard Iremonger wrote: > If the "port config all crc-strip on" command is issued, > The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be cleared. > > If the "port config all crc-strip off command is issued, > The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be set. > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Signed-off-by: Bernard Iremonger Acked-by: Andrew Rybchenko