From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D78DEA04B5; Tue, 12 Jan 2021 05:52:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5171140D3D; Tue, 12 Jan 2021 05:52:37 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id CBE22140D21 for ; Tue, 12 Jan 2021 05:52:35 +0100 (CET) IronPort-SDR: prwmmnwyBL3khsv2ewZiGZgyjhP2rhlH7XvHY92jC2UQ957nsAXc3A2CHMaPIzCLXCJ7jmPz2j BMB0vaAgUiJA== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="196599919" X-IronPort-AV: E=Sophos;i="5.79,340,1602572400"; d="scan'208";a="196599919" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 20:52:35 -0800 IronPort-SDR: 2EbLZgGwqYMqMagcyWfNMeMcdLCTMlQhl7PpfSqOnnZsiePGjmGaq41kpBkcyZM0PJuAaouDk9 EV/qLl+TZ19Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,340,1602572400"; d="scan'208";a="464392688" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2021 20:52:35 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 Jan 2021 20:52:34 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 12 Jan 2021 12:52:32 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Tue, 12 Jan 2021 12:52:32 +0800 From: "Zhang, Qi Z" To: "Guo, Jia" , "Yang, MurphyX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Yang, MurphyX" Thread-Topic: [PATCH v8] net/iavf: fix invalid RSS combinations rule can be created Thread-Index: AQHW5NZm95SuMWzxLEmosyOt6CitbaobYHkAgAgTIvA= Date: Tue, 12 Jan 2021 04:52:32 +0000 Message-ID: <23bc1fb882174110b955f647fbb00d14@intel.com> References: <20210107075815.78873-1-murphyx.yang@intel.com> <20210107091710.84719-1-murphyx.yang@intel.com> <60dba504aba0403e942e7d5692e05773@intel.com> In-Reply-To: <60dba504aba0403e942e7d5692e05773@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8] net/iavf: fix invalid RSS combinations rule can be created X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Guo, Jia > Sent: Thursday, January 7, 2021 5:33 PM > To: Yang, MurphyX ; dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Wu, Jingjin= g > ; Xing, Beilei ; Yang, Murp= hyX > > Subject: RE: [PATCH v8] net/iavf: fix invalid RSS combinations rule can b= e > created >=20 > Acked-by: Jeff Guo >=20 > > -----Original Message----- > > From: Murphy Yang > > Sent: Thursday, January 7, 2021 5:17 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Guo, Jia > > ; Zhang, Qi Z ; Yang, SteveX > > ; Wu, Jingjing ; Xing, > > Beilei ; Yang, MurphyX > > Subject: [PATCH v8] net/iavf: fix invalid RSS combinations rule can be > > created > > > > Currently, when use 'flow' command to create a rule with following > > invalid RSS type combination, it can be created successfully. > > > > Invalid RSS combinations list: > > - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP > > - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP > > > > This patch adds these combinations in 'invalid_rss_comb' array to do > > valid check, if the combination check failed, the rule will be created > unsuccessful. > > > > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") > > > > Signed-off-by: Murphy Yang Applied to dpdk-next-net-intel. Thanks Qi