From: Kevin Laatz <kevin.laatz@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 3/5] app/test: close dma devices during cleanup
Date: Tue, 19 Apr 2022 17:18:58 +0100 [thread overview]
Message-ID: <23dce916-d7fd-7554-41d0-624a9bbb0980@intel.com> (raw)
In-Reply-To: <YlBM2wQCMnbHbPST@bricha3-MOBL.ger.corp.intel.com>
On 08/04/2022 15:55, Bruce Richardson wrote:
> On Fri, Apr 08, 2022 at 03:15:02PM +0100, Kevin Laatz wrote:
>> DMA devices are created during PCI probe of EAL init. These devices need
>> to be closed in order to perform necessary cleanup for those devices.
>> This patch adds the call to close() for all DMA devices.
>>
>> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com> --- app/test/test.c |
>> 6 ++++++ 1 file changed, 6 insertions(+)
>>
> Just to clarify the situation here - on EAL init, all buses are probed and
> all devices initialized. On eal_cleanup/rte_exit the inverse does not
> happen, then, i.e. all probed devices on all buses are not closed, right?
> This would seem a better option than requiring each application to manually
> close all devices even if it never used them. However, it is probably a
> bigger and more complex change.
+1, precisely.
I've prepared an RFC to explore option of adding bus cleanup to
eal_cleanup() to start a discussion on that option.
https://patches.dpdk.org/project/dpdk/patch/20220419161438.1837860-1-kevin.laatz@intel.com/
BR,
Kevin
next prev parent reply other threads:[~2022-04-19 16:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 14:14 [PATCH 0/5] Fix IDXD PCI device close Kevin Laatz
2022-04-08 14:15 ` [PATCH 1/5] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-04-08 14:49 ` Bruce Richardson
2022-04-08 14:15 ` [PATCH 2/5] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-04-08 14:52 ` Bruce Richardson
2022-04-19 16:20 ` Kevin Laatz
2022-04-08 14:15 ` [PATCH 3/5] app/test: close dma devices during cleanup Kevin Laatz
2022-04-08 14:55 ` Bruce Richardson
2022-04-19 16:18 ` Kevin Laatz [this message]
2022-04-08 14:15 ` [PATCH 4/5] app/testpmd: stop and close dmadevs at exit Kevin Laatz
2022-04-12 13:36 ` Bruce Richardson
2022-04-08 14:15 ` [PATCH 5/5] examples/dma: fix missing dma close Kevin Laatz
2022-05-31 16:17 ` [PATCH 0/5] Fix IDXD PCI device close Thomas Monjalon
2022-05-31 16:37 ` Kevin Laatz
2022-06-01 17:10 ` Kevin Laatz
2022-07-03 12:22 ` [PATCH v2 0/3] " Kevin Laatz
2022-07-03 12:22 ` [PATCH v2 1/3] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-07-04 13:19 ` Bruce Richardson
2022-07-04 13:34 ` Kevin Laatz
2022-07-04 13:44 ` Bruce Richardson
2022-07-03 12:22 ` [PATCH v2 2/3] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-07-04 13:23 ` Bruce Richardson
2022-07-04 13:25 ` Bruce Richardson
2022-07-03 12:22 ` [PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove Kevin Laatz
2022-07-04 13:25 ` Bruce Richardson
2022-07-04 15:27 ` [PATCH v3 0/3] Fix IDXD PCI device close Kevin Laatz
2022-07-04 15:27 ` [PATCH v3 1/3] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-07-04 15:39 ` Bruce Richardson
2022-07-04 15:27 ` [PATCH v3 2/3] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-07-04 15:27 ` [PATCH v3 3/3] dma/idxd: fix null pointer dereference during pci remove Kevin Laatz
2022-07-05 19:09 ` [PATCH v3 0/3] Fix IDXD PCI device close Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23dce916-d7fd-7554-41d0-624a9bbb0980@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).