From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690070.outbound.protection.outlook.com [40.107.69.70]) by dpdk.org (Postfix) with ESMTP id B9DBA1B079 for ; Mon, 17 Sep 2018 16:28:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N37W8vA1BVAUzXCVFcvOGLMbeRW23GoKsfqxBxGbock=; b=e0zZy2+FSF1f5BOJb2VYxEyBT3er6TDNUTkU4zf5dSgpTTVMzPTE3qtWXggkccPT+j7dHy93QeSMuNmFuqLYsxSIL5UNUtuILSAEbVeKAg+OGWoq/4GfhLqyjbMl6JDXBh6Gyhd8MUOyKG+OUKxNl/0pD1XFlpMwOKhO/CFLpZY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [192.168.1.9] (223.230.22.245) by BYAPR07MB4902.namprd07.prod.outlook.com (2603:10b6:a02:ef::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Mon, 17 Sep 2018 14:12:44 +0000 To: Akhil Goyal , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Ankur Dwivedi , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-2-git-send-email-ajoseph@caviumnetworks.com> <8421735d-1357-e444-9924-390f23827f3e@nxp.com> <95e172a1-2f81-3e8f-7fba-8373e64428d8@caviumnetworks.com> <06b2d39f-5d9a-d1e2-f3bb-5238e40e6406@nxp.com> From: "Joseph, Anoob" Message-ID: <23e3b8a8-32f9-cd91-bef9-c03eff0d4e46@caviumnetworks.com> Date: Mon, 17 Sep 2018 19:43:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <06b2d39f-5d9a-d1e2-f3bb-5238e40e6406@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [223.230.22.245] X-ClientProxiedBy: MA1PR01CA0118.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::34) To BYAPR07MB4902.namprd07.prod.outlook.com (2603:10b6:a02:ef::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee91e79c-93d1-4119-c391-08d61ca7a5b9 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4902; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4902; 3:8y/G5dEWgC1HZuXbKKEnAzJ/VY9b8nWeizrFwXD908aiww+ZS/z0cI9LUPa6EK2ZLOporxL9XWSnAjpAj362rM2LRVZMT/ZJGdImpukknlFSdVE345rzYbBsqhLpZabB5A4v6N5ApCTuHyNfugaDebiyvGlIHd+mdirvJzrIiz4xSiGKTqrosgYo+Tjsxl22blo8GbTu/91mUFPGk9mCtyBbWmfIlA37mz2KZ6iRpu0ISOGxbkSXh7s2NkJeNd6O; 25:L5ah5HAG91vGmdCrJ7UL3nqWytw1KUY6zlq4IBBS3jAhTXucHqu9d+C+aeKB63K99PD+f17O8oxBYJHDlEgCkROx+OTbQAJsBPQVM7xHInk5mFQzEalHgBMo1Q4bBEKbicSZcIBv1LXrMqMcjn7XrVtKzeJLR1SB3pqp4ASmvILyHhupeMPyo8gF775CyUwE10Ve8uJoSWwAX8FzPEe7WcziRaOcQwDDcdM0VPmGjvZp3ezg4q//LJ50dM64pGbbpGWPiU8ThuTu6aFbsY6G1db03GWNZ01JAeLLyTd+au2wfzW9phr7teMr+kuXdThnHNJnQxi+Hxca7kQVuWvLIw==; 31:dO+fvoWG42Yh+HxsBnQMym+eJDajDzy77ykgv+015NZaZdxHfzfyJec9qX5GlFX1YpibpJe73uSsjkcUo/TrIfXsO2qDWrtzX8CoEXmpGRkHcfC5F94r1v/s5l4pcpRuzzxVGITrRWn8QQPEyDHhYrh1qavZQg5iHWOt4L6fsE39EeWddl9wPAZ+SdALM/VnKJDDlJ1qutkg62JN3MDLQ0ktaFnH62xjaSjx0Xi8m+M= X-MS-TrafficTypeDiagnostic: BYAPR07MB4902: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4902; 20:8rNoATDxdNKaCCctz7KzdCy8R5MiCSA9VRgWVJP2ltdOACC1IFUlGiHQfKGIvVcbhVO9Su2b0FoBxf7oHusZrOtdF1K+WdwuGz1ieeQo1XZtD7LFdUvFzo6HVZhVA8n+AX92SEjFIkw40bxv1d440orW9RkFjtOj/g1jcdaKW3Uw5YNFQmlFL8VuVmELDb1k5Zp+fySyKv886Xm434lTlKJP5DWgQHApDJermQEP78pjRJi1jGgDKHfHiHQ6JpB2INf1WwEksCcfP99Pz/NkUZR7IYQFenFtqkjZXgWLMGHAsHTB3IZ4oCSZx3B/L2XX0tLG0GvIGmuJue9SPCo/mF/uSiJ9uePVh7dUozCPjuBuOkaZymQipjYRImf32Bgar4gYrnIdBw/nbIHQGR5OyO2Xsqjz+oMdKMY58OKKe8vnyMDXL/31kwbm0WmHIgQH/3mbKEVkc6FSxEEpjjEXWAh73e29Cc9cpzhtIv3WkTWSShwdFafYuXJbfcW60OqgzoPJLwSy23hLAEHGop+P0aNsNPL/GX6oitB5nEzGdjX/Ov0E0THEw1EzdoULWpC4q2pAK3TuoRj82LNQplerQtbbyatl0FjYXDS3T397LwM=; 4:cY/UZyM+9Jh+VDBUDa9nGVHFzT9FoAUTAcpku+s9Gq+V4OzUQDqpoPMT2J+7QWqjphk2S3jKJYx0LB5jK6DHthE9C9BInXlSLZKg1zA6akPUZk0MlljnLqKPxTAoxMhL1l2CbMms8/zi6I3UE+3W0GW+u1YzSZFL5iZFDZ+rv7KH7o3Lv1khyLD90fREqoURWIiy7i9mlusj+gUgZn5h0zGrLRa89jZWLWZ/T99tLawfEi8o7aL2PAmkpnIBk8yVoIbepzbO880zmMWX/NpgqQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(201708071742011)(7699050); SRVR:BYAPR07MB4902; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4902; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(396003)(346002)(39860400002)(376002)(136003)(51444003)(199004)(189003)(305945005)(2870700001)(7736002)(50466002)(486006)(2616005)(956004)(11346002)(476003)(81166006)(446003)(81156014)(6246003)(107886003)(31686004)(4326008)(6666003)(68736007)(53546011)(386003)(36756003)(5660300001)(31696002)(65956001)(66066001)(65806001)(65826007)(47776003)(42882007)(16526019)(117156002)(3260700006)(25786009)(14444005)(8936002)(77096007)(26005)(2906002)(54906003)(52116002)(8676002)(2486003)(52146003)(23676004)(67846002)(53936002)(6116002)(110136005)(105586002)(58126008)(3846002)(76176011)(316002)(93886005)(229853002)(106356001)(72206003)(478600001)(64126003)(6486002)(16576012)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4902; H:[192.168.1.9]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWUFQUjA3TUI0OTAyOzIzOnB4TDU2Rm1rc05PSjB0NEM4WnA4dTN2eGNZ?= =?utf-8?B?S1djSjZWTlZTMVBxWmQ0L0dYcUhEdjBlbUo4RnZxNktqMjc3SjVRV2pJOXBZ?= =?utf-8?B?QnBQM3FpZ0ZvMWFDK0dIdnk2NzJydjlaUmd0ckpIMmI5aTY0cno2V1lSeGhP?= =?utf-8?B?NEFic1FTOHhTaklSRkVhd0dScjJPNk5DTDVQZnZtUFZnTklYOWNlTEpTWGZz?= =?utf-8?B?WkNpeXdVMlNOWWxRbDhMZTF4UzNpbW1ZT1BIVk42b2V3ZE5pZjZhTXU1MVEw?= =?utf-8?B?QUZYY2FTcnJRc082RGRCc2FUZlRXNHZYVUtmdnVqU3QvMGNvSVkva2xqNDZ2?= =?utf-8?B?eExqbTNkajcrblJVMGlPanA0RldzbnNieExyL29NQm9EVGkzNlpqaFYwZjBF?= =?utf-8?B?OEoybnIvK0txQklhb3NlM3hhQlVxQVd4R2JweUpzdE5pbG03YlFjS0JtemJ2?= =?utf-8?B?WGJqajkwKzBIcmhNdzFGdGR2RVhPaVMyT1dVNXBDeDJwN0Z4cHF3SXNuYlAz?= =?utf-8?B?SmNKZUN3bU8xMUsydGwya3o2VEZMQTEvSGJDN05ibER1aVZVRU45MFhrWGtS?= =?utf-8?B?Z0pkVENETHNyVUNyT0cwNlVIVTFEbVdvd2MrV3lNV2dsYTVhRW5pQ2ZKTnhm?= =?utf-8?B?clFtNi9PN2R3SXpnT25RekE4OTRZNzB2bFUydHYyMHlmckhybndCWDR0dm9i?= =?utf-8?B?dVlkakFmczhHRjljcnNsMUdZNWp0S0pUdGxiUEROZEpmTWNEYVFFMENOckVU?= =?utf-8?B?YllKc2hiUGM1S040QnNnWDNyOUQ4dkptK1NWOGdmMko4OG1Lbm1DVWExMEtv?= =?utf-8?B?OUlEN0hGS0dLbWJFalU2K3JzTlQ5SkxaQWNnbW9rUi9uZGVtWHozcmFQRHY0?= =?utf-8?B?MzRPdkpoTEZzbjhTZlBEakZOUE1Zb0dtQ1MyYWhjM3pTY1dtRDhuSUVYY2xw?= =?utf-8?B?MC9FSjJ5ZXNOTXYrUjFldnc5bEhxa1RybkRwUSsrOStkU1JCQU9qcjdJYVYz?= =?utf-8?B?VXg0Y3NYLytxVnFlRmhkM045RUtmTzNGOC9GVjRQMFlvMy9lSG5CQ0FvZGZz?= =?utf-8?B?ZFJJWjNIMFU5c0dob3l4bWIzSUZwM1pBcHJiUytTbXY1R040SU1URElyUzBT?= =?utf-8?B?aW5tdzREeXUyQURWSVNHZTlMcTZMbGRCb05FdzFXdTBGYjh3L3N3WWlBdHFP?= =?utf-8?B?QmFyeXZoWTloTExhN29aejYvelJuSEptZ1RuamJkTjd0MnZNMHZJc2h1em1z?= =?utf-8?B?TFBpQThEcitsejhnNGF6ZkNiZFF2djRlMjNqZEdqS21pMnJYUmg5bEFPY2pU?= =?utf-8?B?RW1ROVJ6eHc3K1BZYXFhcUgwVGFFR01zK3BITUhSdUhYbTFiaGRQSEwxdXpB?= =?utf-8?B?VDhWMTFTMkRaUU5vNTJYdmJpalZPZmI0ckdpTUhTcUdXT0lKL3lRNjlRaEI4?= =?utf-8?B?eVYvQnRTdE9SQVI3Sk91NHRNWTRtY0s4aFFVTmVnczBQL0RvcEJtMURRTWli?= =?utf-8?B?K0ZscjJKWk1uRW9Cdk1qd2ducUtTeHhrdW9YeWNGcFRJSzFKTksyRmFvU2k5?= =?utf-8?B?N2FOYkpibDJuWjJobHFuSzMzN2hXRUk0SEdxVWlvUnpSTklMekR1YjMweWNE?= =?utf-8?B?dGpGRS9OMnh4QkxBSTk1Rkk3SEduMjJYbDVZMWpKN1dmOG1pUGNicWM5bHVr?= =?utf-8?B?bzlML0VqRXE2T2JZMnVkQS9zZGxqcUgyNUlGSFgzVTRqTldndEVqcXVLbmwz?= =?utf-8?B?RlBiSkdCQUJTZHZaajgwcWEyUzZNWHVhaGh1bFJsaE9NWW1ZeU43U0Z4ZnRQ?= =?utf-8?B?UlVCdVhuOW4vYXNiRlZpTERRbHJHMlhkV3FWT3FrdjhSZE8yYkhDZHpZMzRu?= =?utf-8?B?SG8yOVFVdG1LYzQrYVJWU2dXcmVHL0VUdmVFbU4xZkcwdFh5MTk2c1ZVUzVO?= =?utf-8?B?ZmdqL3RVM25WMDY5SGUydjU1dlFtYUVSS1lrRjhoUVB4a0MzWm1NVnpqR3gr?= =?utf-8?B?bnJGcWo4dnJIWXFUSlJDYjRhdFVaTFJDTUthSVprdWVweDNLVzhEbUxDbUFm?= =?utf-8?B?ZEhvTlYyRE1GZ0RRTnNuNGVoZnNsSzNobURUUnhsekQ3OFZpYmdkeHZFSUMy?= =?utf-8?Q?uz01bOhkNTA9+zUj1EOLrelfvdgpdHQslPBXlvizmRLw?= X-Microsoft-Antispam-Message-Info: WFSa6bQHy2LLt/kjH52sEozGkfjzbyy/BXV0ItLF6m3zGA1tVhnawqVbb6XMFyO4IvMVAK/yuvHxmjbSgbm86ZfU8QONLt82+P/k/+vaYZ62E9XX1ARxbqpS9Gqi0gK91nFZuhFvGYhnTn1ECOWK54gq1FL+8WB2bewvaf9T2Z4K7L/6RsA5bU7Pak0llSW+SoDBLIJ6TyEBFkHRtYNUx97s/DDkxenGUzxShigKgMK9Jd2YsLI46i6RtXijIC1q+eQKURSRMq4EaHVRD8sPCQR79CbLjrcj03ncHALFyDocwyoLPOG84fs9YfmZX+TOD/P5JSS+0uZ4/ZFetyEg/5fmzujBsHmJfZH0KfGvT0o= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4902; 6:eq164PvKcXidpYssCIY324tZ2Uw45eQVR4PSYBhZAmiTE2xFjYrhF+y/yZWIXR2fy4FzX3TVZWQ+azhPjY/AwSIQ7uUrSxVZ3YBWKuouxYofghMhnYGuzZQPHvN019bOjPfzd3VHrGQtkyCe2yx3xOKMg1gOfgNHCQqD+m4UYXObtpq+TRtVgPdpXB6mBMv+nMP3Xi0U8Sv1O3tUW2w6NM0/TzwMjuXnK8rkf1hIRUd53QRRTutnbgGajaSLStNKqkOdVfqSjn06ZnYoPPa5SH/rFuLNSLLyP/93ok1wemK3Ece1e8qbaV7go8GqJprFjqoX/7Pt3cZiOsFqYcdyIvTzkkqE+Mi2jhccjPOggcLxtYqIFK2I6CERBU35nlQKLHMfmcpuql0uYNkd2RJOK/wA61+nUe4VDFaRhHxIQBMZ7wolgHKrUU7qvytf0VKm98wMclXJsvWv8QsKUov/Aw==; 5:DidzcKR+hEQz2h+XjCWBH/Ga1l3AZ/WXF5sfBdjM/KtDDiRqEK6rnoGUfcDnFHfwV0+w3hrMuo3oK24919K7fQKJ8K1gKIkEP0Shzp9R2YTlhDZISiDLUhJZ2AuVsxg/IqL8pFJd+AhhzUqBfsLAohD/THrB2ViJZv2lP2FWdFk=; 7:M62GV99XtTLd7A3mpER1d92b9/3RsgXpdU5UFluuYjnv5oNv+Hq28Gb+1s8R17lZvnUGwa0FqwdV7tA1zgEE3lkY9iG5PmEZsJ9vOQoL/nlvOb9ql5gvrgWDkVpitkxAOqdnduHTdGOeMjgsJ56FpOv4flBnzO0+rAOqpytR5/2YiQ+A5F+2XIpDAOrqUWIp50dexGmP8zUtF3rRX6pdgY2w4qWrzoVSH/gqpF/5s43aDa/OUaIRLJ46gu6sKE/T SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 14:12:44.8249 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee91e79c-93d1-4119-c391-08d61ca7a5b9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4902 Subject: Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 14:28:30 -0000 Hi Akhil, On 17-09-2018 17:50, Akhil Goyal wrote: > External Email > > On 9/17/2018 5:12 PM, Joseph, Anoob wrote: > >> Hi Akhil, >> On 17-09-2018 16:07, Akhil Goyal wrote: >>> External Email >>>>> I think it would be better to squash the makefile related changes in >>>>> the 3/33 patch as the code >>>>> is actually added in that and here the code is not getting compiled >>>>> here. >>>> So the changes in the following files has to be moved to patch 3/33? >>>>    drivers/crypto/Makefile >>>>    drivers/crypto/meson.build >>>>    drivers/crypto/octeontx/Makefile >>>>    drivers/crypto/octeontx/meson.build >>>>    mk/rte.app.mk >>>> I think this patch will just have MAINTAINER edit (even that might be >>>> required to be moved to 3/33?) & changes to config/common_base, after >>>> that. Is that fine? >>> In my opinion, you do not need this patch as separate one. >>> config/common_base can also be added in the 3/33. >> In that case 02/33 patch would become the first patch right? The same >> problem would be there too, I guess. The macros added in that patch gets >> used only in 03/33 patch. Is that fine? > > I think that would be fine. Better to have a 03/33 patch before 02/33 > if it doesn't have dependencies. 03/33 patch is dependent on 02/33 patch. Shall I proceed with merging 01/33 to 03/33 and make 02/33 the first patch? > >> The first patch would be a shell patch for most PMD additions. That's >> the reason we started this way. If you want it changed, will do so. >> Please do let me know what will be the right approach. > > For the makefiles, you would be compiling the empty files which does > not have any code. That does not make any sense to me. With 01/33 there won't be any files compiled. We are just adding the library (which would be empty) > > Normally, when we submit a new PMD, we add the basic PMD probe/remove > in the first patch and add it into build system. Maintainers is also > updated for the new PMD. > > Further ops are added later in the patchset. > > Hardware specific header files/ functions are added before they are > used in the driver in a single/multiple logical patches. > > In the end, documentation is added along with release note and > MAINTAINERS update for documentation files. I shall proceed with merging 01/33 to 03/33, if you can confirm making 02/33 the first patch is fine. Or please do let me know if you have any other suggestions. Anoob