From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76170A00C5; Tue, 15 Feb 2022 11:47:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BA7A410F3; Tue, 15 Feb 2022 11:47:46 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 9434040E78 for ; Tue, 15 Feb 2022 11:47:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644922064; x=1676458064; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=xufx1KbvhPT4GzKVrN2aiEYvPmMGHt30XfqfeRoOM9I=; b=aHUe1WN7vAm4knyQ/+tid5JPEFLvseGeYJMoMMD7fSdlOZpf/tLQZlih HI52j55y/wO1b2wCrgYm6Vt5/cZQ2DBIqBYVlvx3CPlE2EMubd7omcsd/ gwskae8SKcK20NvZULrSWkJQkLeMpFAMBQUsl7d3xrOS+sBl13waD+72q vXkRVFG2c4eftQDP+61fjGZYcX5se7TVkD2grM9+kF39gCjv4mogcjhvw vqVXXMcbszgMxSr3hc96tNJ+ZF+t8oh/2hmZPPxYxPa9fp7AVLFNcwXjI gwd5rh56qtNfQANrFEyxTJpmMqq6pTaSniTv+EF2zcNZx7ZLVrDwoSSWo Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="250269346" X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="250269346" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 02:47:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,370,1635231600"; d="scan'208";a="775773499" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 15 Feb 2022 02:47:42 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 02:47:42 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 02:47:42 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 02:47:42 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 02:47:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWx82edQ3ny2ED5Oj73MB4A1f5vHtGXo51gfBa0JtWxTY8o+eXP7O9GQy726xDbRUK5xjs3t4ojVodkCJaU17o5Gk/kbJuPG/kDakWh+OjhKtxJxLo+zmSmbfp12LpyzKkT5ZUWyeejWGQaYjpuZwUQN3+Ym/lQioJsd43UkN4UXepj4jG5PCky0UDKR6fpyIn5NFcGjIaqqUgLvrQXLSEbxpcXDhlAhP+tskxLKDE0UpglGz2hrrWThhZJ1HTFD9lzNfe5junsTjecz6ezYdwMTuLFbe1EeMyODiL9+el16qcWjum8PNaOzUnKHk/fsCefbOQZccYUfohWY/nxYzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lkCcjBpwiVUInu3Yiuc/dOrQKA/js+MOcQy1xp2mNDM=; b=Ct/qpSqsAFYi7fQ6LPCfoJaH/FiBCGp03xQpvI8KwMuok+GO54XnWv+0GWUK1pAEmel1PtviGVXS39NasBtYbhAf4liq8HzvZ9E8HeMRVbeu+7vOb7y2FwXjcSC39WmzPp5Ue48RbkmeNmmGMLPoPh0un86ZiE7MPtIcPI/Ty1QcRGSPuOc+GiH6xzWuNkCg2rUOLEu9pG5gWrBh1wwIlKh+nrRarQL9OZzozYzxU1mMpwDXJPvJE6/2FaiwGgi7cYBmf3YNbDTXdsrgvlEr1Gvj3BqzVuUVlTDXJqSFUlGz7eZ6e5k+8ywK5vdKHJ8z6GoTszBxgN71RzUgtVc/Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by SJ0PR11MB5024.namprd11.prod.outlook.com (2603:10b6:a03:2dd::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Tue, 15 Feb 2022 10:47:40 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::dc1a:fca9:c3dd:3657]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::dc1a:fca9:c3dd:3657%3]) with mapi id 15.20.4975.015; Tue, 15 Feb 2022 10:47:40 +0000 Message-ID: <23e5a111-9402-d6ce-a076-5dbcb24f5937@intel.com> Date: Tue, 15 Feb 2022 10:47:33 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.4.0 Subject: Re: [PATCH] net/iavf: fix segmentation offload buffer size Content-Language: en-GB To: Ferruh Yigit , Jingjing Wu , Beilei Xing CC: , , Kevin Traynor , Luca Boccassi References: <20220210130923.1442905-1-radu.nicolau@intel.com> <05a27976-6664-190c-38b7-9b63c7294973@intel.com> From: "Nicolau, Radu" In-Reply-To: <05a27976-6664-190c-38b7-9b63c7294973@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0421.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::12) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d0a49fc-5e68-4eb7-0eaa-08d9f0709664 X-MS-TrafficTypeDiagnostic: SJ0PR11MB5024:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:204; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8yckHkh15ww6cLj3L6GZnBFhe5v4Orp51jRqhmWjevlHRfsNHKIAIccuMgwc8azM2sYVVd9L6e4/ZBFspcfgBRH197j1ibqRdkIMD5UDHN7IpYfiuqOYDp5AT+Bm3ZiJVIIcWAAqxrxJCaHILmhccEvv4oSF3jR4KJCgYLBe7ky2hRWNdvP9QkdYkSCIoc8CAwuR82/Oj81MdkveFAkkdaH7rGmk6ay3T/bcrXn+35kQhtlIoANYKiFLQyC1WlZ9Dflk6fpbV674H8R6tlv8C9rZTB35/1G96+s4IFhv60bqF5F9LE/LJ8OcDa8LZXvMq0+LTaVO/unVSDH7Zax4X2nuJpLOvmdTVmAjP3svYWlj7BBbkfUMuUU2IR2RvgvyS51oriqENhV/HlUK9JK4tKmIz7toyZAuOvHjf+548INxd5dY8nc97TrCUU1YTiwfFCsqNO6Dugtpn2IKMhLyYepAsMFGEZPB+gfS/pT9fhFpnydPf7BLwIJtqHiStPFU5C3zuglyVw+PdOHMVBsSoZkulh7JDipLFK3k+rDmeWRNedDYR9mNnLKGdfgkQ9Hvx9nmABI/5yz7nzSTQdVR5p54AM/UUv8gC7rrPyoYVvIUhkG0M3eYef6lOjZohO9CqHdEBaFoVaIvzhSwBjc6bQ8dgHrwuZINd3O2g+923eRrNw7git8bqjZeqoSDNnj2j6QQatGZWKWL9rt7a8zjPw+0bkwc/ioAB+XdsSemvPU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(6512007)(53546011)(55236004)(4744005)(6506007)(2616005)(186003)(26005)(508600001)(4326008)(316002)(31696002)(31686004)(36756003)(110136005)(8676002)(86362001)(6636002)(6486002)(54906003)(6666004)(82960400001)(66946007)(5660300002)(38100700002)(66556008)(66476007)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3hDMHQ2Q3p0ei9MRitGWVNDT2R1MUpYZWFidHNNOXNqTFFCTVFDTDFkRjY5?= =?utf-8?B?d1ltVUkrL3NSWWFwL3hSUDgvRkdMaEpOYkNvaDgrd0M1aHpWSnZnVnpwVEtF?= =?utf-8?B?SlB2SUNaQVpJSVdEWFp5THVRRk1ZbHcyR29Sem1vb2V6dTlFYUZFblk3SEpR?= =?utf-8?B?L1dOam55MFBqRWg0Y09RZVZ6WmxaNG5ERDFnS1ZKbHN6aWc5dEFUUTc0WnRF?= =?utf-8?B?cG16eWxmZ1NTczB5YldoK0hLQ0ltSzl0cVBSVDFWcUh4ZDI5Q1VBY1ZmSGtH?= =?utf-8?B?NDNRQVFIR3JDZ1VVUG9xRjNhQkE5d1hmSGZEb2VHb0dlT3c5UmtlU0I1Z1RS?= =?utf-8?B?U1prMzlZcGZEZWdDVEVxb3BnNktzR1dpY0JyL0hKdXFXb2xtS1pEQ0dxenVY?= =?utf-8?B?ci9iNlFNVWVmUHJ1Q2VPU2ZEWEx0dnZRcnIxVm5wRFpWWlJ2cnlPVjNZc0xk?= =?utf-8?B?aVNOdEw4azNPblBXOCtyWmFZMWRiQmpQT3BtR0xRK21hTktEYW9DZVNHNy9q?= =?utf-8?B?bzRwTEhDdUpYSnRlaHpSa3ZGd0toYmFFaVJHbEVTU21RQ3c1OE9qR3IvRUNk?= =?utf-8?B?V2NLamw3ZkI2N2R5Z3dpdGRNendXOHI5cnUyQUtxYmpxN0Q1MnRRVERaS0Zm?= =?utf-8?B?MGhBRmVoVWtxTlhRalJBY0ZHOXkxTUZ6SW85UjdNM0lxd2xLeDcySlYxK2dE?= =?utf-8?B?T2xmNExwdDlaa2locmtWZDBnejBGQVRneXVUaUdsVks3Z3h4aUpjaXNjc21I?= =?utf-8?B?OE05VEJrWlZkbERZdkd4SllWL3dOc292VGhNb2RrRFBncEVNdTE2ZTNHclVY?= =?utf-8?B?TmdXOHViWHZOUFhOajl3S2tBRmV0YjNrcEoxOGZEOWVpNW85UVZwUlA1TjA0?= =?utf-8?B?dW1YMnNNaXc4TGF2Rm5EVFAzM2h5WXdncmFxbTg0U3kwQWQyUlpQVFBQL0hV?= =?utf-8?B?RXRDYWVrMTFrVlNhY1dPL2poU3ZBRTJXUmphZlRRWDZFaUtsMnRBbTB4Y3U4?= =?utf-8?B?anlLZkVxZkdJYVEreDFGOWtGT05GOEtaTmFNa3ZORzRDY2tPZ0w1YWJ3eFlU?= =?utf-8?B?TnFKM3pjNXVmOVIxKzNlS2VFRlhYZ09SbDI1YzJOTDZtTmFnblNQRis0eEhj?= =?utf-8?B?MVdEWEN4WWNvZjlKZytOYlB1WkFSRmg4UnpHOW1KR1RoRzY3eWxyYmxRUVln?= =?utf-8?B?RHlBbVZEU2ZjYmN1dzVqY0lmdjFDZUFERG1LR1UvK2FjSVNRMzJGVmNKRzNm?= =?utf-8?B?ZEdjbytKRHdtMElxenFCQTFUbldxaTdGMWM5Q0NYVldqejcvZXU1ZFpDSk1i?= =?utf-8?B?SVdJR3VxMmFlSzBvMWxhWDIvTXZxdmpUNzYza2NLRTFvQ3l0NDR3RER2bURP?= =?utf-8?B?WXE3eCtFZFlJUXBLTUxVYmdneXVoNHFJSzNOb2prMTd4V2p5SDFaWnVleG16?= =?utf-8?B?Q2FJY2lGdWxWQjNHUXBkbVJnVnNreEhnYVFtSTFyWmovaEFMSjdIRzJwZkZp?= =?utf-8?B?emg5bHBsaWk1Z1RwbHhvNEE5b3JXeE5WekRRU2h4WVVEU24zWmh5SVRNYVVV?= =?utf-8?B?alZ1TE5Pc21nSmdWMFI4RWQzUXNRMnR0SWpVcTc5NWNib1JpckxTbGNkWi9U?= =?utf-8?B?cmdYbDI3ZVJDTTZXNHRwYWJnRm5PVlRrRFhlcHpXT3ZMSGZVSWl3aVJjdEVD?= =?utf-8?B?T2svN0dPOUdJNHZVMTZld3BHanVQUWtQc0hTY0E0amVNODFubjJRVWZVOWs0?= =?utf-8?B?bGswKzEwM2ltK3hLUk1lYko5akxKekdGMWdvVkVVN05lRSs1Mlh1ZGdpOXRT?= =?utf-8?B?bFpHRi8zMjdsb0RqaWUrYkxjaklObmFKOHVnREgzQ2lrczZqeDNGSllvZUZn?= =?utf-8?B?WDgzWThPYlNadzNWYWVZeVZtb3VsKzNXK3lrREorU2Y0cnNMU3dpTW5TVmo0?= =?utf-8?B?ZnlvYmJReFZnbVJ5dHZsMERwd05FTnpzS294bG4yV2RMSk5ab0ltUU1RcTM0?= =?utf-8?B?QlhISzY4SDFqQzZSS09xS2V3eEhoUnhRSmxxenEvcTdmRk9NZldMM3lubVhE?= =?utf-8?B?VjIxK2d0cGJZbVlNSjRDZ0d3Nml1WkMycUs0N2hJYXdTY2FzdVhSOTVCaU1O?= =?utf-8?B?aHU1dFplRE5mcmIzdGVIN1N2b05XcTVZMyszWDd1TmtydnVBcU5LdXdCalVv?= =?utf-8?Q?g8RXik13D9oTvG8Ea99zhLc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4d0a49fc-5e68-4eb7-0eaa-08d9f0709664 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 10:47:40.2434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JwngmG3XjbTOphUQV5Yuu2X3nX0ZqZ1I+IAI1RxQ84g9Q5hF7D/y+rI8kMICCZfgFlIrnj5Yr2nhrWHrKFl5og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5024 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 10:06 AM, Ferruh Yigit wrote: > On 2/10/2022 1:09 PM, Radu Nicolau wrote: >> This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer >> size >> being computed for TSO packets. >> >> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") >> > > Commit 'ff8b8bcd2ebe' was already fixing segmentation offload, > are we having the initial issue back when this patch reverted? > Is there a fix for that initial issue? The initial issue was around a very specific usecase - IPsec transport mode TSO and it is very likely back with this revert. But it's a much less severe impact than general traffic TSO.