From: Hemant Agrawal <hemant.agrawal@oss.nxp.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com
Subject: Re: [PATCH v2 2/2] drivers: replace printf with fprintf for debug functions
Date: Tue, 2 Jul 2024 22:56:03 +0530 [thread overview]
Message-ID: <23ea33f9-2e88-4be7-cd4b-b29cc264c7b2@oss.nxp.com> (raw)
In-Reply-To: <20240702081112.530a5f11@hermes.local>
On 02-07-2024 20:41, Stephen Hemminger wrote:
> On Tue, 2 Jul 2024 16:10:13 +0530
> Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
>>
>> - printf("\n JD before conversion\n");
>> + fprintf(stdout, "\n JD before conversion\n");
>> for (i = 0; i < 12; i++)
>> - printf("\n 0x%08x", ctx->jobdes.desc[i]);
>> + fprintf(stdout, "\n 0x%08x", ctx->jobdes.desc[i]);
> Don't see the point of this change, printf() and fprintf(stdout) are same thing.
Yes, but no harm in this change. It was originally a script based change
in the files. Now the code is consistent - only using fprintf. Either
with f or with stdout.
next prev parent reply other threads:[~2024-07-02 17:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 10:29 [PATCH 1/2] drivers: replace printf with log macros Hemant Agrawal
2023-02-15 10:29 ` [PATCH 2/2] drivers: replace printf with fprintf for debug functions Hemant Agrawal
2023-02-15 15:16 ` Thomas Monjalon
2023-02-16 9:27 ` Hemant Agrawal
2024-07-02 9:31 ` David Marchand
2024-07-02 9:59 ` Hemant Agrawal
2023-02-15 17:17 ` Stephen Hemminger
2024-07-02 10:40 ` [PATCH v2 1/2] drivers: replace printf with log macros Hemant Agrawal
2024-07-02 10:40 ` [PATCH v2 2/2] drivers: replace printf with fprintf for debug functions Hemant Agrawal
2024-07-02 15:11 ` Stephen Hemminger
2024-07-02 17:26 ` Hemant Agrawal [this message]
2024-07-02 12:15 ` [PATCH v2 1/2] drivers: replace printf with log macros David Marchand
2024-07-02 13:08 ` [PATCH v3 1/3] " Hemant Agrawal
2024-07-02 13:08 ` [PATCH v3 2/3] bus/dpaa: remove double newline Hemant Agrawal
2024-07-02 13:08 ` [PATCH v3 3/3] drivers: replace printf with fprintf for debug functions Hemant Agrawal
2024-07-03 10:41 ` [PATCH v3 1/3] drivers: replace printf with log macros David Marchand
2024-07-03 12:02 ` Hemant Agrawal
2024-07-03 12:11 ` David Marchand
2024-07-03 12:16 ` [PATCH v4 " Hemant Agrawal
2024-07-03 12:16 ` [PATCH v4 2/3] drivers: dpaa: remove double newline Hemant Agrawal
2024-07-03 12:16 ` [PATCH v4 3/3] drivers: replace printf with fprintf for debug functions Hemant Agrawal
2024-07-03 14:54 ` [PATCH v4 1/3] drivers: replace printf with log macros David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ea33f9-2e88-4be7-cd4b-b29cc264c7b2@oss.nxp.com \
--to=hemant.agrawal@oss.nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).