From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67FE1A09E4; Thu, 28 Jan 2021 19:21:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 283E940682; Thu, 28 Jan 2021 19:21:07 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 27A764067A for ; Thu, 28 Jan 2021 19:21:05 +0100 (CET) IronPort-SDR: EmDe6GtbRmxmTSrHQQQ5ApxsIC4xyyck7ZKcXDrrkp6ByQpdc8cFGmOT6jXqnl40oZSnRXvaO4 NYSqiPolZ8Rw== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="199122521" X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="199122521" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 10:20:41 -0800 IronPort-SDR: D1rc9GDWJhc9EmeDMH2AUuhNvqLC3VL5DGgJ2no6zoAAHzvqIHXnJv4XDaj/Pk8cN1tWSnKUpG 1HuxLGrSww7A== X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="388936819" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.127]) ([10.213.197.127]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 10:20:40 -0800 To: Ido Goshen Cc: dev@dpdk.org References: <20210125175836.87200-1-ido@cgstowernetworks.com> From: Ferruh Yigit Message-ID: <23f32b85-9e81-e16e-4aa0-173e1955a65c@intel.com> Date: Thu, 28 Jan 2021 18:20:37 +0000 MIME-Version: 1.0 In-Reply-To: <20210125175836.87200-1-ido@cgstowernetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/1] net/pcap: imissed stats support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/25/2021 5:58 PM, Ido Goshen wrote: > Signed-off-by: Ido Goshen <...> > @@ -695,6 +708,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > stats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes; > rx_packets_total += stats->q_ipackets[i]; > rx_bytes_total += stats->q_ibytes[i]; > + unsigned long rx_missed = eth_stats_get_pcap_missed(dev, i); > + if (rx_missed) > + rx_missed_total = rx_missed - > + internal->rx_queue[i].rx_stat.missed_reset; 'ps_drop' seems u_32 type, do you know how it behaves on overflow? Do you think do we need a check here for overflow?