Re: [dpdk-dev] [PATCH] meson: Update flags and values for ppc_64

[Thomas Monjalon <thomas@monjalon.net>]

04/06/2019 22:25, dwilder:
> On 2019-06-03 15:30, Thomas Monjalon wrote:
> > 27/05/2019 11:41, Bruce Richardson:
> >> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote:
> >> > Setting RTE_MAX_LCORE to reflect the largest available configuration.
> >> > Adding defines for missing RTE_MACHINE_CPUFLAGs.
> >> >
> >> > Signed-off-by: David Wilder <dwilder@us.ibm.com>
> >> > ---
> >> > --- a/config/ppc_64/meson.build
> >> > +++ b/config/ppc_64/meson.build
> >> >  # overrides specific to ppc64
> >> > -dpdk_conf.set('RTE_MAX_LCORE', 256)
> >> > +dpdk_conf.set('RTE_MAX_LCORE', 1536)
> >> >  dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> >> >  dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
> >> 
> >> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > 
> > Suggested title:
> > 	config: update for ppc build with meson
> > 
> > Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well
> > for RTE_MAX_LCORE?
> 
> Hi Thomas
> I am taking the opportunity to update RTE_MAX_LCORE for future releases 
> of dpdk.  As we are switching to meson builds soon so this is an 
> appropriate opportunity to update the value and keep in step with the 
> hardware. Older stable release can continue to use the smaller value 
> found in deconfig..

I don't understand the logic.
You are updating only the new release.
Some users may use make and others meson.
There is no reason they don't have the same config.