From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ABF72A0096 for ; Tue, 4 Jun 2019 23:05:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7513B1B997; Tue, 4 Jun 2019 23:05:00 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3A8E02B8E for ; Tue, 4 Jun 2019 23:04:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A528921FC3; Tue, 4 Jun 2019 17:04:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 Jun 2019 17:04:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vkmK9l4aQHYFmCxJa67b8oTamDB2hcERrL4aEDyw0q0=; b=ZL8KEt6oiNB+ +/U7ToW2qm969jTZ7dyvy3ZiRKgdyBbtzTBp9ysuWezsWUMTHw5KfHxK/bvZdBkx h5ntY+Jo6jlaNcLo4QkFtOoUIZdH6ZMq5vtomOgOoUgRP/z4hb06T9LxmUg2A+zv 8fSB2XoE2yCHqKjpiul6+bMATnfns1M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vkmK9l4aQHYFmCxJa67b8oTamDB2hcERrL4aEDyw0 q0=; b=Ar7hkTFYaplcfRKVYgT2VOXysGNLFZS/gNlUVAzPQLpAcyn0ptgikmfqA jfNIs2Ul4++g6+v297TNDjQYQk9rQmjfqJDWe/ISjVmE1yVaHLO5YStmcEzDQAC0 iDKiRDT6hqCgPcMbeql95QfOfPoWp4ROcFdZJt6F5GlvXO0eQXhq1Qi0F+lj1kEi a7faw48uisWc2iUIc4ON3t+yjgayoXEotroChFP1yV3q1I6z9fpptU4WujYWJOG8 7mCvduOr/E+k7Ak0y6djgWGL4Hdot/IEa+tjlVdVzniU6GX+JDEHj7Ziq8yZastv IpK4bM3y714vh3YQ7s2z3MklNIQ9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudegtddgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D623D80060; Tue, 4 Jun 2019 17:04:56 -0400 (EDT) From: Thomas Monjalon To: dwilder Cc: dev@dpdk.org, Bruce Richardson , pradeep@us.ibm.com, drc@ibm.com Date: Tue, 04 Jun 2019 23:04:54 +0200 Message-ID: <2400087.3yNoXGUXWg@xps> In-Reply-To: References: <20190524160404.15896-1-dwilder@us.ibm.com> <1864604.tGcSgmW0Rt@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] meson: Update flags and values for ppc_64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/06/2019 22:25, dwilder: > On 2019-06-03 15:30, Thomas Monjalon wrote: > > 27/05/2019 11:41, Bruce Richardson: > >> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote: > >> > Setting RTE_MAX_LCORE to reflect the largest available configuration. > >> > Adding defines for missing RTE_MACHINE_CPUFLAGs. > >> > > >> > Signed-off-by: David Wilder > >> > --- > >> > --- a/config/ppc_64/meson.build > >> > +++ b/config/ppc_64/meson.build > >> > # overrides specific to ppc64 > >> > -dpdk_conf.set('RTE_MAX_LCORE', 256) > >> > +dpdk_conf.set('RTE_MAX_LCORE', 1536) > >> > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > >> > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128) > >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1) > >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1) > >> > >> Acked-by: Bruce Richardson > > > > > > Suggested title: > > config: update for ppc build with meson > > > > Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well > > for RTE_MAX_LCORE? > > Hi Thomas > I am taking the opportunity to update RTE_MAX_LCORE for future releases > of dpdk. As we are switching to meson builds soon so this is an > appropriate opportunity to update the value and keep in step with the > hardware. Older stable release can continue to use the smaller value > found in deconfig.. I don't understand the logic. You are updating only the new release. Some users may use make and others meson. There is no reason they don't have the same config.