From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] rte_log: remove unnecessary stubs
Date: Thu, 15 Jan 2015 14:34:24 +0100 [thread overview]
Message-ID: <2401477.11STyzvieH@xps13> (raw)
In-Reply-To: <20141209083546.12e936b7@urahara>
> The read/seek/close stub functions are unnecessary on the
> log stream. Per glibc fopencookie man page:
>
> cookie_read_function_t *read
> If *read is a null pointer, then reads from the custom stream
> always return end of file.
>
> cookie_seek_function_t *seek
> If *seek is a null pointer, then it is not possible to perform
> seek operations on the stream.
>
> cookie_close_function_t *close
> If *close is NULL, then no special action is performed when the
> stream is closed.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied
Thanks
--
Thomas
prev parent reply other threads:[~2015-01-15 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 16:35 Stephen Hemminger
2015-01-15 13:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2401477.11STyzvieH@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).