From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1A9C43989 for ; Fri, 18 May 2018 11:47:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B0614220C1; Fri, 18 May 2018 05:46:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 18 May 2018 05:46:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=YqBpfX+5g3FXTOqLZDOSejheEG 6nZfCx/lMw0CVue68=; b=AAaRAEZbCzMCLKXDxS3b09n7YdJpRr7tzgTNC9rChQ RmG0ZcbwxZMKvImDWowieZcFEaRgk2k7xw/bA8v2TS9D8QV4cM7C1aaAYkqYoA81 CIioot/+A5IRBpSnSoHth8wpKZp9KKuDmHmk69yeSSIpkustEd2gNX9JlwxIPX6B 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YqBpfX +5g3FXTOqLZDOSejheEG6nZfCx/lMw0CVue68=; b=fkeXSzk080dVUtmNuCtRmS kLjIhuxibNnGeGtRxh5yZcF0yrZv+cVwARH69F1i91wWfgqvkO3Aqr/nCFwBafpC ShKww8zKbkinsJr7pZbzgaeZV4wdQL0C486WAP7RYD2FaBfjiRUc6eGIZNEbUCmI NZBUyi3odstDms1qYUMqrJi7Wqqyy4UlCOwK0crOyvASwYwI123SaJaDbQnN9bbN TA1GNSgi8fUJxdR2JxW/jet2lFuaCgEa6NfdiRkyh4ZD5f81nEmJUH9U8gIbGyFe Q7E6qsf0KXQJ00QuyPpAjJXWctEZ7j3ynYePCMMmmaSgEdxg0/1KzQxVmOhZ39sA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D467BE4B34; Fri, 18 May 2018 05:46:58 -0400 (EDT) From: Thomas Monjalon To: "Yang, Zhiyong" , "Liu, Yong" Cc: dev@dpdk.org, "Wang, Zhihong" Date: Fri, 18 May 2018 11:46:57 +0200 Message-ID: <2401955.4lgGG0bg7M@xps> In-Reply-To: References: <1524909247-6581-1-git-send-email-yong.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: using initial-exec model for thread local variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 09:47:00 -0000 28/04/2018 06:39, Yang, Zhiyong: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu > Sent: Saturday, April 28, 2018 5:54 PM > > > > When building share library, thread-local storage model will be changed to > > global-dynamic. It will cost additional protect for read thread local variable. By > > now only lcore id is this kind of varaible and not need to dynamic share with > > other threads. So make TLS model back to initial-exec like static library for > > better performance. > > > > Signed-off-by: Marvin Liu > > > > For vhost-user, > If no this pach, vhost user in shared lib perf drops 14.3% than working in static. > after applying the patch , vhost-user in shared lib can achieve the similar perf as in static lib. > > Tested-by: Zhiyong Yang For the record, I have decided to not try this optimization in the last weeks of the 18.05 release. However we could try it in 18.08 by applying the patch early in the cycle. Is there anyone against this patch?