From: Thomas Monjalon <thomas@monjalon.net>
To: maxime.coquelin@redhat.com,
Hernan Vargas <hernan.vargas@intel.com>,
nicolas.chautru@intel.com
Cc: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Subject: Re: [PATCH v2 5/5] baseband/acc: cosmetic log changes
Date: Fri, 14 Jun 2024 23:12:11 +0200 [thread overview]
Message-ID: <2402510.9XhxPE3A7Q@thomas> (raw)
In-Reply-To: <4775841.neEnAmRlxL@thomas>
14/06/2024 23:04, Thomas Monjalon:
> 02/05/2024 22:45, Hernan Vargas:
> > - rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"\n", desc->req.word0);
> > + rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"", desc->req.word0);
>
> Why keeping an empty string after PRIx32? Should I remove it when pulling?
> The title should be about removing superfluous empty line?
I'm quite sure answers are "yes", so I move forward.
Also please rename log functions in all bbdev PMDs as they are defined inside the drivers.
For instance you should rename rte_bbdev_log to acc_log in this driver.
Same for rte_bbdev_log_debug.
next prev parent reply other threads:[~2024-06-14 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 20:45 [PATCH v2 0/5] ACC100 improvements and clean up Hernan Vargas
2024-05-02 20:45 ` [PATCH v2 1/5] baseband/acc: fix memory barrier Hernan Vargas
2024-06-07 12:45 ` Maxime Coquelin
2024-05-02 20:45 ` [PATCH v2 2/5] baseband/acc: remove ACC100 unused code Hernan Vargas
2024-05-02 20:45 ` [PATCH v2 3/5] baseband/acc: remove ACC100 HARQ pruning Hernan Vargas
2024-05-02 20:45 ` [PATCH v2 4/5] baseband/acc: improve error description Hernan Vargas
2024-05-02 20:45 ` [PATCH v2 5/5] baseband/acc: cosmetic log changes Hernan Vargas
2024-06-14 21:04 ` Thomas Monjalon
2024-06-14 21:12 ` Thomas Monjalon [this message]
2024-06-12 9:09 ` [PATCH v2 0/5] ACC100 improvements and clean up Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2402510.9XhxPE3A7Q@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).