From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EBB7A052A; Wed, 27 Jan 2021 14:23:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21210140D97; Wed, 27 Jan 2021 14:23:56 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 1B3F4140D8E for ; Wed, 27 Jan 2021 14:23:55 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 800F25C0134; Wed, 27 Jan 2021 08:23:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 27 Jan 2021 08:23:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= hb4iAGqQzz/mVw9oA4WhUPnDSnIzs7jOWxpcOpZF0Rk=; b=VMltkDJ7hYMytHAP fOaXOcYLQCbr1llh0QvOR5bezPbCvm1kX0ZtlU2TJndSY2BIjIkbu0pyTGKBDBlT YI3jzlTZLBtU1yxBaFNPMm2+Hq6/pZZFDVdjEBdVKLo3IL3ZOtDnfO4z5x1nbLRU 0Y6zz32YSbRbpGIkvmE5KkxlT9Py/cQfosQbJc5yuLFiOuFH8rOZhzEMQVJaiTsM gkMxuG9kR1J1NQIyHpIpgh5FfnLK66+boinhr7F0t1eaKufEmCslyi89jBH0vhUl s/INioXV6lGUiTlnBGxPffRonkRgv/0bCWf2KO+4CTK5mO9Z7/LVUNrphsca1hmx lCC4mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=hb4iAGqQzz/mVw9oA4WhUPnDSnIzs7jOWxpcOpZF0 Rk=; b=jGBEfv+ICVIfxSjAlhUOVenQkK9Kz0IDQnMPWQNLtVRlj10dm8dCTNfXN DuIADgUvOpuUNxRbRb8X4/TkPiH8MvXyWWhMiSmMj7Kd2pFMwRkMHFsdbLikbIPS qn+WtdH8P1NmAdzQv9qWTop/XJgoTAsiYD21hrJc5uHsfJJ+W8yxgI9Ub500XscZ KEh0eSiAtcVxJeQhAGyiC8cuFU/j3U66F51XDPzvhci4ORHw0FrZfutuhFZqlCj8 uxN+YId8qlu5ChItje9u1UXuT/12KrgsajYeg2GfxyrDgfTLp6ToCeoWToybjvXk z1vvb9a67uaQVjUNAvjD2yJA29mOQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9130524005A; Wed, 27 Jan 2021 08:23:53 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org Date: Wed, 27 Jan 2021 14:23:52 +0100 Message-ID: <2403128.NMugI9Su5r@thomas> In-Reply-To: References: <20ad523bdee024979dfc74cc32c8c02954cd1d4c.1610984505.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mem: improve parameter checking on memory hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/01/2021 18:17, Anatoly Burakov: > Currently, we don't check anything that comes in through memory hotplug > subsystem using the IPC, because we always assume the data is correct. > This is okay as anyone having access to the IPC socket would also have > rights to crash the DPDK process through other means, but it's still a > good practice to do parameter checking, so fix the code to do that. > > Signed-off-by: Anatoly Burakov Applied, thanks