DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	David Marchand <david.marchand@redhat.com>
Cc: Bing Zhao <bingz@nvidia.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions
Date: Tue, 26 Oct 2021 14:59:12 +0200	[thread overview]
Message-ID: <24049921.3QzFLNkSy1@thomas> (raw)
In-Reply-To: <DM6PR11MB4491226AEFD9F7183D3786D69A849@DM6PR11MB4491.namprd11.prod.outlook.com>

26/10/2021 14:38, Ananyev, Konstantin:
> 
> > > > > > > > There is a concern about getting efficient log report,
> > > > > > > > especially when looking at CI issues.
> > > > > > >
> > > > > > > +1.
> > > > > > > The current solution with logs is a real pain.
> > > > > >
> > > > > > Are you guys talking about problems with
> > > > > > app/test/sample_packet_forward.* David reported?
> > > > > > Or some extra problems arise?
> > > > >
> > > > > The problem will arise each time an app is misbehaving.
> > > > > That's going to be a recurring problem in the CI.
> > >
> > > It is still not clear to me why it is going to be a recurring one?
> > > Ok, right now we have some test-cases that are misbehaving unintentionally.
> > > So we need to fix them.
> > > I admit that it might be a pain, but it still looks like a one time job to me.
> > > With new test-cases we should be able to catch such misbehaving at patch
> > > submission stage (by checking then logs).
> > > I guess there might be some test-cases that misbehave intentionally -
> > > some negative test-cases for error-condition checking etc.
> > > But for them error message in the log and error return value seems like a
> > > right thing, no? Again I expect such test-cases do erroneous rx/tx_burst
> > > just few times (not dozens or hundreds) so they shouldn't pollute log too much.
> > > So, what I am missing here?
> > 
> > You don't miss anything, but as you said above, we are going to catch
> > some issues at patch submission stage.
> > And we want this stage to be easy to catch.
> > Having megabytes of log does not help to check in the CI.
> > 
> > > > One thing that could be done is compiling with asserts in CI, and let
> > > > default build not have those asserts.
> > >
> > > Agree, log+assert seems like a good alternative to panic() for me.
> > >
> > > > Otherwise, logging once should be enough (I have a patch for this latter idea).
> > >
> > > I understand the intention, but I am a bit sceptical about that one:
> > > it is quite often people don’t pay much attention to single log message.
> > 
> > Not a good argument in my opinion.
> > One error == one log.
> > We are not going to flood all error logs to make sure devs pay attention :)
> 
> Well, that error could come from different sources (rx/tx, different ports, etc.).
> But yes, healthy CI is important.
> So if suppressing subsequent messages will help it anyhow, I wouldn't object.
> Few thoughts though:
> we probably need to make it more informative (and scary :)) then now:
> bump log-level, print current lcore id and dump current call-stack.
> Another thought - might be worth to make it logging once per lcore
> (instead of global logging once).

David tried to print once per queue.
I don't know whether it can work. David?



  reply	other threads:[~2021-10-26 12:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 21:14 Bing Zhao
2021-10-22 21:14 ` [dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset Bing Zhao
2021-10-23  8:34   ` Thomas Monjalon
2021-10-23 11:39     ` Ananyev, Konstantin
2021-11-10 14:34       ` Ferruh Yigit
2021-11-10 14:37         ` Ananyev, Konstantin
2021-11-10 14:57           ` Thomas Monjalon
2021-11-10 15:24             ` Bing Zhao
2021-10-23 16:13   ` [dpdk-dev] " Stephen Hemminger
2021-10-24  5:54     ` Bing Zhao
2021-10-23  8:32 ` [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions Thomas Monjalon
2021-10-23 11:46   ` Ananyev, Konstantin
2021-10-23 12:45     ` Bing Zhao
2021-10-24 11:48       ` Ananyev, Konstantin
2021-10-25  9:43         ` Thomas Monjalon
2021-10-25  9:51           ` David Marchand
2021-10-25 12:55             ` Ananyev, Konstantin
2021-10-25 13:27               ` Thomas Monjalon
2021-10-25 13:31                 ` David Marchand
2021-10-25 20:29                   ` Ananyev, Konstantin
2021-10-25 20:38                     ` Thomas Monjalon
2021-10-26 12:38                       ` Ananyev, Konstantin
2021-10-26 12:59                         ` Thomas Monjalon [this message]
2021-10-26  3:18                   ` Bing Zhao
2021-10-23 12:12   ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24049921.3QzFLNkSy1@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bingz@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).