* [dpdk-dev] [PATCH] tools: Fix typo in dpdk_nic_bind.py script.
@ 2016-02-09 0:33 Jeff Shaw
2016-02-09 11:10 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Shaw @ 2016-02-09 0:33 UTC (permalink / raw)
To: dev
We should call sys.exit(), not divide sys by exit().
Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
---
tools/dpdk_nic_bind.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py
index f02454e..a1923c5 100755
--- a/tools/dpdk_nic_bind.py
+++ b/tools/dpdk_nic_bind.py
@@ -317,7 +317,7 @@ def unbind_one(dev_id, force):
f = open(filename, "a")
except:
print "Error: unbind failed for %s - Cannot open %s" % (dev_id, filename)
- sys/exit(1)
+ sys.exit(1)
f.write(dev_id)
f.close()
--
2.1.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] tools: Fix typo in dpdk_nic_bind.py script.
2016-02-09 0:33 [dpdk-dev] [PATCH] tools: Fix typo in dpdk_nic_bind.py script Jeff Shaw
@ 2016-02-09 11:10 ` Bruce Richardson
2016-02-09 11:42 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2016-02-09 11:10 UTC (permalink / raw)
To: Jeff Shaw; +Cc: dev
On Mon, Feb 08, 2016 at 04:33:46PM -0800, Jeff Shaw wrote:
> We should call sys.exit(), not divide sys by exit().
>
> Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] tools: Fix typo in dpdk_nic_bind.py script.
2016-02-09 11:10 ` Bruce Richardson
@ 2016-02-09 11:42 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-02-09 11:42 UTC (permalink / raw)
To: Jeff Shaw; +Cc: dev
2016-02-09 11:10, Bruce Richardson:
> On Mon, Feb 08, 2016 at 04:33:46PM -0800, Jeff Shaw wrote:
> > We should call sys.exit(), not divide sys by exit().
Obviously :)
> > Signed-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-09 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09 0:33 [dpdk-dev] [PATCH] tools: Fix typo in dpdk_nic_bind.py script Jeff Shaw
2016-02-09 11:10 ` Bruce Richardson
2016-02-09 11:42 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).