From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DAA081AEF4
 for <dev@dpdk.org>; Thu, 30 Nov 2017 23:03:58 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 65C7B20D90;
 Thu, 30 Nov 2017 17:03:58 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Thu, 30 Nov 2017 17:03:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=iAVbOy2pFRpY9ncVgGe3obLtvh
 IQTk0zE1gCX2jKvSA=; b=GsyxZo9yekavPQqyKyoSx+48s01lcIgx9xP5sMkZUb
 uk+VHcMgnKp2WiO3LIDl/hQHAt27sZbYFhcF4V/6tdc+12lJ9d91u2F1Wsz3HJsG
 PaJb96Ovg0NmTwtmtrg2J4wlF/RehuoAgDf1bzA57PhnIQOFU0AubZ/0CpNKhvOz
 0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=iAVbOy
 2pFRpY9ncVgGe3obLtvhIQTk0zE1gCX2jKvSA=; b=jhyBG8itm+sqwWFwy7U56V
 sR4CnDX8lGSVhr0EcsVFS4kbviratu1/9iQUq53n9LGx9E+MY3NRIgRqg0kQZgXi
 1MRsf5cMajMkKNY3Xu6hIQSSMSkhn0jfF+9Bqpd6YQWxnXGjSc2GVjhooxak/yZg
 eLIH7uKy78ht7/x/uHzwpVYipT8gI8BX1Ld0Tq1Nqr5Zcv53wbYmQ2scqKQNFDC1
 fwkhdchGNhugeYSPdYCHGP2Xh5KnuRNbRuEeT6tdfIp2Leyw9gFAeNdbLYCv6Eqr
 EU7MqgscEqcmDBYlc4B6MO4w1/RJV6SLCB1bniBOned2FAAL1EWPRJfSb1VI1HcA
 ==
X-ME-Sender: <xms:ToAgWkIFb9krbdQCdgcSKkqM3Bq9DK1Y12FQSZIS95TstcM6FeUquw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1B5ED24ED4;
 Thu, 30 Nov 2017 17:03:58 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Date: Thu, 30 Nov 2017 23:03:57 +0100
Message-ID: <2407814.uAEd4ZzsLf@xps>
In-Reply-To: <20171130135551.458330e2@xeon-e3>
References: <20171130214720.30098-1-thomas@monjalon.net>
 <20171130135551.458330e2@xeon-e3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Nov 2017 22:03:59 -0000

30/11/2017 22:55, Stephen Hemminger:
> On Thu, 30 Nov 2017 22:47:20 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > +	for (int reg = 1; reg < 4; reg++)
> > +		memcpy(name + (reg - 1) * 4, &regs[reg], 4);
> > +	name[12] = '\0';
> 
> C99 style declarations are not generally used in DPDK.

True :)
It will be fixed in v2.

I think I should add a log somewhere at initialization in order
to test this function.
Do you think it deserves a table of name strings in the .h?