From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id BB56958C8 for ; Fri, 2 Dec 2016 11:37:53 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id f82so11778485wmf.1 for ; Fri, 02 Dec 2016 02:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=dyC6kvlyR6jqDg0Bxyx5aO2tcG8/wMUtaCOKtSwO4eg=; b=QbrUTBJz5TZiQkxR2i2mzWoDaSPS8Fh0WhLqRtiJfJ7/CSlVSxaNr25I7a3PlBpdxB SB3hp3hqVFRunm2UuBYBAw0sll0cdC9wkx4ewMFSA7fIwaGzwMq4F66YURPMy/X6DFEE mas9El2M23y8JmG0XMyT5RM0xa7/nfTAIXdZvsaTC9h9tvVeOA0hEem2CO4qsy6pCAin zACDmLbcfM3wch24ItdNcwvBMF+C9yNfn2iRyzYdYJhDpOuHjbmnMGi2/Pv/oQxUKe97 Z1InxXLfRwFcCjQAt3OTtIBJ525sXJ+sY+MocRDId8aCAPaV1ZHNsGQNlmdPcj/D1LU7 psag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=dyC6kvlyR6jqDg0Bxyx5aO2tcG8/wMUtaCOKtSwO4eg=; b=ChSw6GKn7FXn4KnmmN/9fTy9hl3/GQgQi9psPJgS35GjwtpWGKAba0KlufXgLb6fM5 J19wAzjc70SgvguvoJbLZmpgeOzKzMIzT5rg59KZ7vps2CaypzvWAQW1aDkQFSUKZY1z W6C6931+mTeXslVpBqpSuW2xdRr99GpAASWnnj9YZfpQLc10tsBKTLlVPUzVbEk5toUI RlCIKpZwhVd2YUsyQ3X1EvTPdeINNNU82WNG4XX/kDod99qEFANlcGdLeXaPPz4N+Cep efI82o3HQ93Sqv5kz4WVCPSzcvms04b1HB9c4C0tyqggKctvEXhu1+waUrUCVsDXQ8N2 sOVA== X-Gm-Message-State: AKaTC01s94wuc3+aLC35XH0/nq1D1O8X6RCmNA7ZGzMesl6GWYBNqXXOELQ3vVRVXslCWJ4e X-Received: by 10.28.149.135 with SMTP id x129mr2355231wmd.71.1480675073515; Fri, 02 Dec 2016 02:37:53 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c187sm2506925wmd.13.2016.12.02.02.37.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Dec 2016 02:37:52 -0800 (PST) From: Thomas Monjalon To: Declan Doherty Cc: dev@dpdk.org Date: Fri, 02 Dec 2016 11:37:51 +0100 Message-ID: <2408315.PI9TjJa4bq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1480671985-3677-3-git-send-email-declan.doherty@intel.com> References: <1480671985-3677-1-git-send-email-declan.doherty@intel.com> <1480671985-3677-3-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] crypto/aesni_mb: add new option to select SIMD mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 10:37:53 -0000 2016-12-02 09:46, Declan Doherty: > Add new initialisation option to the aesni_mb_pmd to allow the user to specify > which set of SIMD functions to load from the AESNI Multi-Buffer Crypto for IPsec > library. Why let user choose? Isn't the most recent the better? This PMD and other software crypto PMDs could (should?) override the CFLAGS like rte_acl do, in order to be able to use recent SIMD functions even if it was globally disabled by the compilation target. See my comment in the rte_memset thread.