From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5E16A04B5; Fri, 2 Oct 2020 13:07:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A9381D560; Fri, 2 Oct 2020 13:07:51 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 27F151D55D for ; Fri, 2 Oct 2020 13:07:48 +0200 (CEST) IronPort-SDR: 6ahm1D6H44BQPXuNwfrHuMG2R1SOxFxNbKtFfQJqvNxQ1DXGN8CuIJQ9Rkq3Nok9Q24z9p7R1P NZ6QcNREB+bg== X-IronPort-AV: E=McAfee;i="6000,8403,9761"; a="150597770" X-IronPort-AV: E=Sophos;i="5.77,327,1596524400"; d="scan'208";a="150597770" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 04:07:39 -0700 IronPort-SDR: 0fKQn8FXPV2ChMqqTsga+eRSKwVfNGIA3fJMwjomOaChF4UjgJnLh9ac1W5euQeqyRPg8LMf8S B0lUlIdkMz4g== X-IronPort-AV: E=Sophos;i="5.77,327,1596524400"; d="scan'208";a="515870365" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.213.230.23]) ([10.213.230.23]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 04:07:37 -0700 To: David Marchand , Thomas Monjalon , Bruce Richardson Cc: dev , "Burakov, Anatoly" , Robin Jarry , Stephen Hemminger , Ray Kinsella , Neil Horman , John McNamara , Marko Kovacevic , Timothy Redaelli , Luca Boccassi References: <20200929102224.440322-1-kevin.laatz@intel.com> <20200930114024.446473-1-kevin.laatz@intel.com> <20200930114024.446473-12-kevin.laatz@intel.com> From: Kevin Laatz Message-ID: <2408b5c3-eb3c-2b2b-b7ce-5ed70bf35c08@intel.com> Date: Fri, 2 Oct 2020 12:07:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/10/2020 12:01, David Marchand wrote: > On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz wrote: > [...] >> try: >> import sphinx_rtd_theme >> diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst >> index 0be9546a6a..4fc010ca49 100644 >> --- a/doc/guides/contributing/coding_style.rst >> +++ b/doc/guides/contributing/coding_style.rst >> @@ -765,7 +765,7 @@ specializations, run the ``app/test`` binary, and use the ``dump_log_types`` >> Python Code >> ----------- >> >> -All Python code should work with Python 2.7+ and 3.2+ and be compliant with >> +All Python code should work with 3.2+ and be compliant with >> `PEP8 (Style Guide for Python Code) `_. > I am for dropping any mention of a version here. > On current HEAD of the main branch, the requirements already ask for a > 3.5 version. > I would simply ask for PEP8 compliance in this doc. > > Opinion? > +1 That was something i concidered while making the patch - saves someone maitaining the versions here in future. - Kevin