From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AFD7B4CA6 for <dev@dpdk.org>; Fri, 14 Sep 2018 09:46:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 12E6F20D9E; Fri, 14 Sep 2018 03:46:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 14 Sep 2018 03:46:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=OgCsfJjfS80jKiGrate0UG2uoC 7DolVVBA7C2pIETqk=; b=IhaU0EDFRx82UExtt5KcQEv/hlVqcZZHUN9ReDHsJg yx51aVVjv5UjVpJUX1LXbUvOubR4xB0MPBHqU3nKvcVOUgQEBISqCxJBWiDSCzIy rL+QBr257Uf18hKJ7hgi8TB/kzaiE/WzI5CUxKSZlp/3EqgRGmVadviuVjVjWNsd I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OgCsfJ jfS80jKiGrate0UG2uoC7DolVVBA7C2pIETqk=; b=EXQo8bpwbG1xwM1tjKOn3U Fuw9Y0mruRGrP9BuhnVRdePQ3t4Vf+BRfGjL1JrVhIb0F+PZ2utSKxlvRpS9FKPc NIxKlXT4+3t1M83fA5UAocdgP00+I75gcoKx7Lu/d2HRbE/TbB/Q8DcmDQD5HK6n yYcfppWtqMsxyQMmZZDhoeT7ihuU6I4wQkgVsxVYyYy32S5GTOozoNZH5dkc87Lv hfXWbUsjjtq8Ik/LG68qZoJ3LZOsdA8lqw4fmqammsuvHQPqbUXE8i+EZaYfFoHi lLP5Dq4ZO7dYkhGPWytA5XPYYbSFpaD6U87BeEZsC93SE3YsvmU0JyfM8euGFjMA == X-ME-Proxy: <xmx:Z2ebW6wqdLk5kMMEMSo8T7OLtN_jxiKGbtzwsQEWIelTC_8TigLEzw> <xmx:Z2ebW3g4_Yg0ZynekIvok1i-J5Wu1zxf-zdJ7u5txhe1RhB7KgrLEA> <xmx:Z2ebW-F_9pkJ4Lz15ivVvC9GBjVcbzJeCuFWMsYbpZm-wHbqeYFWAA> <xmx:Z2ebW5_xwVZZ6ozgIS9VXAaj1QqenU6lhd5ynFgKgU3ZXHyeEl0QFA> <xmx:Z2ebW8OloZl-tq6TZ4qDI4Kle3fwcxDLdalbr8_byR9bntNkBIh0xQ> <xmx:aWebWw36hThqC1jm5_7Q77kN8imVmwLSHzaMcWAOl2s4bO189wxhOA> X-ME-Sender: <xms:Z2ebW3FPUW1_50xE-uPAmT9lppckOWtA2W3_5YTX5J4LQbDedMNJjQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5F811E46B6; Fri, 14 Sep 2018 03:46:45 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Yong Wang <yongwang@vmware.com> Cc: Luca Boccassi <bluca@debian.org>, "dev@dpdk.org" <dev@dpdk.org>, "keith.wiles@intel.com" <keith.wiles@intel.com>, "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>, "jingjing.wu@intel.com" <jingjing.wu@intel.com>, "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>, "rasesh.mody@cavium.com" <rasesh.mody@cavium.com>, "harish.patil@cavium.com" <harish.patil@cavium.com>, "shahed.shaikh@cavium.com" <shahed.shaikh@cavium.com>, "amr.mokhtar@intel.com" <amr.mokhtar@intel.com>, "shijith.thotton@cavium.com" <shijith.thotton@cavium.com>, "ssrinivasan@cavium.com" <ssrinivasan@cavium.com>, "liang.j.ma@intel.com" <liang.j.ma@intel.com>, "peter.mccarthy@intel.com" <peter.mccarthy@intel.com>, "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>, "maciej.czekaj@caviumnetworks.com" <maciej.czekaj@caviumnetworks.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "antosh.shukla@caviumnetworks.com" <antosh.shukla@caviumnetworks.com>, "ashish.gupta@cavium.com" <ashish.gupta@cavium.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com> Date: Fri, 14 Sep 2018 09:46:43 +0200 Message-ID: <2409775.xiy84CyIAu@xps> In-Reply-To: <C7A3B202-963B-46BB-93B2-D3AFB406EDD7@vmware.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-15-bluca@debian.org> <C7A3B202-963B-46BB-93B2-D3AFB406EDD7@vmware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 14 Sep 2018 07:46:52 -0000 13/09/2018 23:44, Yong Wang: > From: Luca Boccassi <bluca@debian.org> > The library is called librte_pmd_vmxnet3_uio, so rename the map > file and set the name in the meson file so that the built library names > with meson and legacy makefiles are the same > > Signed-off-by: Luca Boccassi <bluca@debian.org> > --- > > Not directly related to this change but I have some question on the uio naming. The original motivation is from the following commit: > > commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66 > Author: Thomas Monjalon <thomas.monjalon@6wind.com> > Date: Fri Mar 21 13:52:17 2014 +0100 > > vmxnet3: rename library > > In order to distinguish clearly this implementation from the extension > vmxnet3-usermap, it is renamed to reflect its usage of uio framework. > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: Thomas Graf <tgraf@redhat.com> > > However, this version of vmxnet3 can also be bound to vfio-pci driver. I think having the uio naming in that case will be misleading. Yes, i agree. vmxnet3-usermap is not maintained anymore, so we can remove the uio suffix.