From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AFD7B4CA6 for ; Fri, 14 Sep 2018 09:46:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 12E6F20D9E; Fri, 14 Sep 2018 03:46:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 14 Sep 2018 03:46:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=OgCsfJjfS80jKiGrate0UG2uoC 7DolVVBA7C2pIETqk=; b=IhaU0EDFRx82UExtt5KcQEv/hlVqcZZHUN9ReDHsJg yx51aVVjv5UjVpJUX1LXbUvOubR4xB0MPBHqU3nKvcVOUgQEBISqCxJBWiDSCzIy rL+QBr257Uf18hKJ7hgi8TB/kzaiE/WzI5CUxKSZlp/3EqgRGmVadviuVjVjWNsd I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OgCsfJ jfS80jKiGrate0UG2uoC7DolVVBA7C2pIETqk=; b=EXQo8bpwbG1xwM1tjKOn3U Fuw9Y0mruRGrP9BuhnVRdePQ3t4Vf+BRfGjL1JrVhIb0F+PZ2utSKxlvRpS9FKPc NIxKlXT4+3t1M83fA5UAocdgP00+I75gcoKx7Lu/d2HRbE/TbB/Q8DcmDQD5HK6n yYcfppWtqMsxyQMmZZDhoeT7ihuU6I4wQkgVsxVYyYy32S5GTOozoNZH5dkc87Lv hfXWbUsjjtq8Ik/LG68qZoJ3LZOsdA8lqw4fmqammsuvHQPqbUXE8i+EZaYfFoHi lLP5Dq4ZO7dYkhGPWytA5XPYYbSFpaD6U87BeEZsC93SE3YsvmU0JyfM8euGFjMA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5F811E46B6; Fri, 14 Sep 2018 03:46:45 -0400 (EDT) From: Thomas Monjalon To: Yong Wang Cc: Luca Boccassi , "dev@dpdk.org" , "keith.wiles@intel.com" , "roy.fan.zhang@intel.com" , "jingjing.wu@intel.com" , "wenzhuo.lu@intel.com" , "rasesh.mody@cavium.com" , "harish.patil@cavium.com" , "shahed.shaikh@cavium.com" , "amr.mokhtar@intel.com" , "shijith.thotton@cavium.com" , "ssrinivasan@cavium.com" , "liang.j.ma@intel.com" , "peter.mccarthy@intel.com" , "jerin.jacob@caviumnetworks.com" , "maciej.czekaj@caviumnetworks.com" , "arybchenko@solarflare.com" , "antosh.shukla@caviumnetworks.com" , "ashish.gupta@cavium.com" , "bruce.richardson@intel.com" Date: Fri, 14 Sep 2018 09:46:43 +0200 Message-ID: <2409775.xiy84CyIAu@xps> In-Reply-To: References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-15-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 07:46:52 -0000 13/09/2018 23:44, Yong Wang: > From: Luca Boccassi > The library is called librte_pmd_vmxnet3_uio, so rename the map > file and set the name in the meson file so that the built library names > with meson and legacy makefiles are the same > > Signed-off-by: Luca Boccassi > --- > > Not directly related to this change but I have some question on the uio naming. The original motivation is from the following commit: > > commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66 > Author: Thomas Monjalon > Date: Fri Mar 21 13:52:17 2014 +0100 > > vmxnet3: rename library > > In order to distinguish clearly this implementation from the extension > vmxnet3-usermap, it is renamed to reflect its usage of uio framework. > > Signed-off-by: Thomas Monjalon > Acked-by: Thomas Graf > > However, this version of vmxnet3 can also be bound to vfio-pci driver. I think having the uio naming in that case will be misleading. Yes, i agree. vmxnet3-usermap is not maintained anymore, so we can remove the uio suffix.