From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07F2145DA7; Tue, 26 Nov 2024 08:47:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 915794025F; Tue, 26 Nov 2024 08:47:37 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id F28A4400EF for ; Tue, 26 Nov 2024 08:47:35 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XyF335rvqzPnZ5; Tue, 26 Nov 2024 15:44:47 +0800 (CST) Received: from kwepemf500004.china.huawei.com (unknown [7.202.181.242]) by mail.maildlp.com (Postfix) with ESMTPS id E2A841800A7; Tue, 26 Nov 2024 15:47:33 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemf500004.china.huawei.com (7.202.181.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 26 Nov 2024 15:47:33 +0800 Message-ID: <240c5047-7f42-97f8-71ab-b0f78d434e59@huawei.com> Date: Tue, 26 Nov 2024 15:47:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 1/3] ethdev: add description for KEEP CRC offload To: Stephen Hemminger CC: , , , , Thomas Monjalon , Allain Legacy , , , References: <20240206011030.2007689-1-haijie1@huawei.com> <20240719090415.1513301-1-haijie1@huawei.com> <20240719090415.1513301-2-haijie1@huawei.com> <20241122091055.5e87f298@hermes.local> From: Jie Hai In-Reply-To: <20241122091055.5e87f298@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemf500004.china.huawei.com (7.202.181.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Stephen Hemminger Thanks for your review. I will add doc and fix on drivers in the next version. The test will be done later. On 2024/11/23 1:10, Stephen Hemminger wrote: > On Fri, 19 Jul 2024 17:04:13 +0800 > Jie Hai wrote: > >> From: Dengdui Huang >> >> The data exceeds the pkt_len in mbuf is inavailable for user. > unavailable > >> When KEEP CRC offload is enabled, CRC field length should be >> included in the pkt_len in mbuf. However, almost of drivers >> supported KEEP CRC feature didn't add the CRC data length to >> pkt_len. So it is very necessary to add comments for this. > > All drivers must do the same thing, or this is a serious bug > in the drivers. Just changing a comment is not going to be helpful. > > To fix this right: > 1. Do a test with one of the original drivers in DPDK that has this > feature. I would suggest ixgbe, mlx5 or bnxt. > I can test it on ixgbe and mlx5. > 2. Add a test to the PMD tests that validates this (if there is not > one already). > Maybe later and not come with this patchset. > 3. Put the documentation in a place where it shows up in user documentation. > Either in doxygen comment or in doc/guides/nics > Will add in the next version. > 4. Verify that all devices conform to the desired behavior > > I can help, but only have some old mlx5 cards to test here. Thanks. > Just putting comment in ethdev.h is not enough. > Thanks, Jie Hai >