From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
by dpdk.org (Postfix) with ESMTP id C03B647CD
for <dev@dpdk.org>; Thu, 21 Jul 2016 15:35:11 +0200 (CEST)
Received: by mail-wm0-f53.google.com with SMTP id o80so25604496wme.1
for <dev@dpdk.org>; Thu, 21 Jul 2016 06:35:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=nbdzVelqkBLOu7gLx1b6eqzIeoVQIACyUWzDix2mQWc=;
b=vZN/cKkwLT6ofW/9LolvenvY6idEEdR5pV1p+SnHukKu2aHI8Et2l/xKYq59kzbS6A
t7MXBoJz48Ko4xY3+UEfvG/cLCniMxJ6CpF6E266FEAwfnrUwGcBsfR4pAE2jaRyoKak
Htkj2IqwfLG394ZUrA/TNxJ/4Mp0TOx9ohvRfp0ECRa7XBsMuoYxfXg7TAFOWJQNNvlm
ujIejao5h7Zdij2OjOUdGiHzZsjwM3l5v4OXH3cTK1+Kk7mTpmH1Qlug3gkiYwHW3ZKj
Pe+NStyTmwsAz38+Ey+f8QdREsbe8h9j76vtUh2RCeV66k4WHo88iBf2sVW2cFOo6lYt
Naiw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=nbdzVelqkBLOu7gLx1b6eqzIeoVQIACyUWzDix2mQWc=;
b=R7uhW39yyFvL9aogcUvU98TKog6tm6mGlfzDh798BU0Bqj+3F656APJYHrbRIUApy/
2Psa344mmz5jwj2UixEq/2I8JuRpmejre+xf3A5eFCa1AxgeuG75HgvGBePR2MxbcyDN
ZhA1OQ0bn8YLwfcyup1zdzEKdCaJhyMssEudW2BARdBRTq19BGfwf0oxxqsQpikDjlAT
g7uk3iagUgN6N3kRLrp69zlPVFrINZO7fkT+wz4sTYg0FAMpHQYLxyQ9JZX98ODYn3I6
QOyKvy+TTxVLTbtr0o3tVUzpAQNwhTH7Hur6fLa/J5yZpYKtyqOwP5dBcW82vDQlbl2q
sdIQ==
X-Gm-Message-State: ALyK8tLcsfa9UwqGi0Jp+5nUSzpAj3ExlO3vxe1nw9ZPLuZtAbj5tbEShDZ7cV60aWGezRLa
X-Received: by 10.28.9.67 with SMTP id 64mr18512523wmj.36.1469108111484;
Thu, 21 Jul 2016 06:35:11 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
by smtp.gmail.com with ESMTPSA id d64sm4130654wmc.22.2016.07.21.06.35.10
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Thu, 21 Jul 2016 06:35:10 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>,
Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, David Hunt <david.hunt@intel.com>
Date: Thu, 21 Jul 2016 15:35:09 +0200
Message-ID: <24109515.NGORzl0sje@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <887a9e8d-b7cf-4148-d749-5019b206405e@6wind.com>
References: <1469101787-7186-1-git-send-email-santosh.shukla@caviumnetworks.com>
<887a9e8d-b7cf-4148-d749-5019b206405e@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jul 2016 13:35:11 -0000
2016-07-21 15:28, Olivier Matz:
> Hi Santosh,
>
> On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> > removing ptr var. Now freeing mp_stack var.
> >
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > ---
> > app/test/test_mempool.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
> > index 46ad670..3b21cf7 100644
> > --- a/app/test/test_mempool.c
> > +++ b/app/test/test_mempool.c
> > @@ -506,7 +506,6 @@ test_mempool(void)
> > {
> > struct rte_mempool *mp_cache = NULL;
> > struct rte_mempool *mp_nocache = NULL;
> > - struct rte_mempool *mp_ext = NULL;
> > struct rte_mempool *mp_stack = NULL;
> >
> > rte_atomic32_init(&synchro);
> > @@ -605,7 +604,7 @@ test_mempool(void)
> > err:
> > rte_mempool_free(mp_nocache);
> > rte_mempool_free(mp_cache);
> > - rte_mempool_free(mp_ext);
> > + rte_mempool_free(mp_stack);
> > return -1;
> > }
> >
> >
>
> Strange, it seems these modifications were present in latest patch from
> David Hunt (v6). Maybe a bad manipulation during the push?
Yes sorry, it seems to be a wrong manipulation, the v5 was pushed.
This patch seems to fix my error, thanks.
> The "Fixes:" line should be added though.
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>