* [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter
@ 2015-12-15 16:05 Robin Jarry
2015-12-15 16:41 ` Van Haaren, Harry
0 siblings, 1 reply; 3+ messages in thread
From: Robin Jarry @ 2015-12-15 16:05 UTC (permalink / raw)
To: harry.van.haaren; +Cc: dev
This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
The ierrors counter still includes imissed for ixgbe. This behaviour is
not consistent amongst all drivers. Another patch may be needed to unify
the meaning of the ierrors counter.
Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")
Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 1b6cd8efe815..4c4c6dfb1622 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2546,6 +2546,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
}
/* Rx Errors */
+ stats->imissed = total_missed_rx;
stats->ierrors = hw_stats->crcerrs +
hw_stats->mspdc +
hw_stats->rlec +
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter
2015-12-15 16:05 [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter Robin Jarry
@ 2015-12-15 16:41 ` Van Haaren, Harry
2015-12-15 17:06 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Van Haaren, Harry @ 2015-12-15 16:41 UTC (permalink / raw)
To: Robin Jarry; +Cc: dev
> From: Robin Jarry [mailto:robin.jarry@6wind.com]
> Subject: [PATCH] ixgbe: restore imissed stat counter
>
> This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
>
> The ierrors counter still includes imissed for ixgbe. This behaviour is
> not consistent amongst all drivers. Another patch may be needed to unify
> the meaning of the ierrors counter.
>
> Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")
>
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
There is work to be done to allow easier distinction between
drops due to the host, and errors due to bad packets.
Until that work is done, write the dropped packet count to imissed, so:
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter
2015-12-15 16:41 ` Van Haaren, Harry
@ 2015-12-15 17:06 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-12-15 17:06 UTC (permalink / raw)
To: Robin Jarry; +Cc: dev
2015-12-15 16:41, Van Haaren, Harry:
> > From: Robin Jarry [mailto:robin.jarry@6wind.com]
> > Subject: [PATCH] ixgbe: restore imissed stat counter
> >
> > This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
> >
> > The ierrors counter still includes imissed for ixgbe. This behaviour is
> > not consistent amongst all drivers. Another patch may be needed to unify
> > the meaning of the ierrors counter.
> >
> > Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")
> >
> > Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
>
> There is work to be done to allow easier distinction between
> drops due to the host, and errors due to bad packets.
>
> Until that work is done, write the dropped packet count to imissed, so:
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-15 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-15 16:05 [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter Robin Jarry
2015-12-15 16:41 ` Van Haaren, Harry
2015-12-15 17:06 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).