From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D850A0A02; Tue, 18 May 2021 12:33:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DACD04068E; Tue, 18 May 2021 12:33:48 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id BA86440041 for ; Tue, 18 May 2021 12:33:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 00BD55C0127; Tue, 18 May 2021 06:33:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 18 May 2021 06:33:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= pCPy3U4DmpotzCL5U46nafTDTLyl/Pv3+jMAMMIP0BQ=; b=XiNwd8B0PDaejngV lohWmqWifWREG6i3KGUPEqaRwPkQkRRtXs6U/WdrfN2bYbIN3zlOQTNDI6i0nJfy M5TMMER69perU8IKO0WjEAPpRbupoy8VB8kn7EWkIoTLFSOgox63AwPgx7299MKa IMQIbCMQxaI6Z4/apdTLEcIhOTfgytZ+kJu3zcuECMxiFgdSJdvIwVC4x6cWYgd5 B5VT0WwVyniS4ap/QLoz1jEyaT02mjzFLz5btjfZPvNf7/7Pr9MoXZO8cT60zQWC wMeCB65vsprkg45tU0iYfs/lsujrUUZi/yvMCwwkBI4WbY52eD2QPCQMkNDbeXgs DKgkNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=pCPy3U4DmpotzCL5U46nafTDTLyl/Pv3+jMAMMIP0 BQ=; b=Nz2MOepiaLJq7FwoAirW7Ncw0v6MnJLNSB4R8OZAn6qvcr9pCCuPNkI8c OWLfuaJ4iFIDQQVUeBPrVQ6akn+tq+4+brVTK8q33MxlmkxvgSLZVt0hm52IOvYo fbS/BBFbI2jZycKwtFU6eXbplhgzHOBBrOeAcDb/bhOh0aiopQDoLp2UD1WjKo/o BcdeeGq4gEf6wT8V7TsXMlLQDe8LOC6Q1w2NHBFBwDBGYF09j/ChDxgwnfq7wxbR M/VaQO7hTM/4xTcAqCQXgywh+IkdpslHYqGpcCXZXOTSafSkuIOsQAnsPuE2F2j9 C7Yfgx7JSBTzd8rRUl3MX/wajn5vA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeijedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 May 2021 06:33:45 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, Asaf Penso , bruce.richardson@intel.com Date: Tue, 18 May 2021 12:33:44 +0200 Message-ID: <2411400.IrOuIJcBVo@thomas> In-Reply-To: <778def48-a0db-8353-dd5c-1d254a778230@intel.com> References: <1612458325-13508-1-git-send-email-asafp@nvidia.com> <20210407223320.2952469-4-thomas@monjalon.net> <778def48-a0db-8353-dd5c-1d254a778230@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/05/2021 12:51, Ferruh Yigit: > On 4/7/2021 11:33 PM, Thomas Monjalon wrote: > > The script check-doc-vs-code.sh may be used to add > > some automatic checks of the doc. > > > > If run without any argument, a complete check is done. > > The optional argument is a git history reference point > > to check faster only what has changed since this commit. > > > > In this commit, the only check is for rte_flow tables, > > achieved through the script parse-flow-support.sh. > > If run without a .ini reference, it prints rte_flow tables. > > Note: detected features are marked with the value Y, > > while the real .ini file could have special values like I. > > The script allow parsing exceptions (exclude or include), > > like for bnxt code which lists unsupported items and actions. > > > > Overall great to be able to generate and check document against code, also good > to have this by relatively small/simple scripts, thanks for the work. > This helps to remove the maintenance concerns I had. > > > Signed-off-by: Thomas Monjalon > > --- > > devtools/check-doc-vs-code.sh | 79 ++++++++++++++++++++++++++++++++++ > > devtools/parse-flow-support.sh | 76 ++++++++++++++++++++++++++++++++ > > Will there be automated checks as part of the build system? Presumably in > 'developer_mode'? I think we should discuss what could enter in developer mode or not. I'm afraid it will become a mini-CI and will make compilation longer for everybody. > btw, scripts points out some new features not documented in .ini files, those > are the recently added ones, patch requires a rebase on top of latest code. OK I am rebasing. > > +rte_flow_support() # > > +{ > > + title="rte_flow $1s" > > + pattern=$(echo "RTE_FLOW_$1_TYPE_" | awk '{print toupper($0)}') > > + list "$title" "$pattern" | grep -vwE 'void|end' > > Should 'RTE_FLOW_ITEM_TYPE_ANY' also excluded, does it have benefit to have it > as listed? This item may be unsupported by some PMDs, so I think we need to report it.