From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B4805A495 for ; Mon, 22 Jan 2018 00:13:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2DA8320719; Sun, 21 Jan 2018 18:13:25 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 21 Jan 2018 18:13:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Zu4lLL8F9tUtJ6yu6mqRs3djIU C0RB/NMqme8MD68lI=; b=N6kUcdG0UgdTOsy+aaJUeEANA0+tryrFyg5jyeAYOE eEMMgPkpncqgJ1ZDnjaAF3pMzo8ABAY4fGa2vR4qAggC7g9mCBekk9UBC48OxTLS icSuJRPuVlAl7vHtl7+jfJf7gZmHlrUrCRM3rYgyYLaEhiCQ5eYZX+f7lt9eiMXr 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Zu4lLL 8F9tUtJ6yu6mqRs3djIUC0RB/NMqme8MD68lI=; b=MpaGAklx0V/b6pQOqPiUf0 Q6/cabBgl2YyO3jln2xYLy0cV/ApeT3dju0ySL4kPKgM5y5YFVEmSVY4bvn7fGwF coztTTH3QbCj3J1puNwwm9djGt9DaeH5YNF0xUpL/MhDmNtqiX2D7FiIfq83frOn 1o6jrAQXtKSLPR7I4ZwqxQ6qwUU2OcOnNL01pNgFGdamSOoqElYyzQdZb61hCgm2 J8RdKGNaiYtkhRhks9O6bXfT5SmiYn82c1ZdnTQA8Tx23KsdK2eBV6uiyedco7TU QE6lbYP5tkwViRqvb5tiGn+NaZVD9+c9AfusLbXOZUvvdIMHHXc4zFvrwxNorjjg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CDEC92463E; Sun, 21 Jan 2018 18:13:24 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Mon, 22 Jan 2018 00:12:47 +0100 Message-ID: <2413567.jYmEStPfnM@xps> In-Reply-To: <20180120165746.21209-1-ferruh.yigit@intel.com> References: <20180117215802.90809-1-ferruh.yigit@intel.com> <20180120165746.21209-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: separate driver APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 23:13:25 -0000 20/01/2018 17:57, Ferruh Yigit: > Create a rte_ethdev_driver.h file and move PMD specific APIs here. > Drivers updated to include this new header file. > > There is no update in header content and since ethdev.h included by > ethdev_driver.h, nothing changed from driver point of view, only > logically grouping of APIs. From applications point of view they can't > access to driver specific APIs anymore and they shouldn't. > > More PMD specific data structures still remain in ethdev.h because of > inline functions in header use them. Those will be handled separately. > > Signed-off-by: Ferruh Yigit > Acked-by: Shreyansh Jain > Acked-by: Andrew Rybchenko It is really hard to review, especially patches 2 and 3. But I really like the idea, so Series Acked-by: Thomas Monjalon Let's take this change in 18.02-rc1.