From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 91DDAA0AC5 for <public@inbox.dpdk.org>; Mon, 27 May 2019 10:31:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A3D9137D; Mon, 27 May 2019 10:31:28 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id F3227F94 for <dev@dpdk.org>; Mon, 27 May 2019 10:31:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4F593220C9; Mon, 27 May 2019 04:31:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 27 May 2019 04:31:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rF07v1m8ke2mTv48ShDDRQzW3XntC170AQQ81cPeUD8=; b=UMQHKy0w2BbC rZnf0bFxER5uSL5fpM/RiQlJrxqRPN7S/MK+7TPuuVSYa6TpW8r4MvsrwjYynVsv RJ3R3yIzL8RF9zg2IBEblHJOreqBzUu2k7K+zLqoga7tj+zFmlI6xDsJ2HjB9ZAa dcMedQuMj56W+3ISlmMaRKZwUA5jLrk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rF07v1m8ke2mTv48ShDDRQzW3XntC170AQQ81cPeU D8=; b=Zo3zs3mp5Yyt3o5RRaxSx49bh2TOXJb8EJUi4xnfdpGWPKs+lplsG1lXS o//tb8jN5Iz4JYjNKqM+XP40b7zxHRu7afun7VotwN1eI88kgjcuDyMB8VwalpBd 99xT6BG4Ka1mZ2m8vAll1ZL5JDr3H9NIaxA92Dr1RefQdNmFUItW0MbM+1eGrldD hPfgFvUSZ4lzAKBiUnlZXKTpXDOPTW5dI4xdR0TgZX09gvTpqb7Bg8wP2OP0hmf6 UyCgBoEMyiX9xozHBudkonf8ZKao0zkMMEreUyUyZxnLcdZ1inbmhPK5Tvtl4Jc5 pAo5uSjO1FKyffFaLEOcEe0k+Zkwg== X-ME-Sender: <xms:XaDrXMmbTgz6MN9GWIHqexB9dZwnRjnEwX32St5GF33R4_eQSVfRqw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddvvddgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:XaDrXNrVY871Tov54tjFU1MoSegZf82njr8cz2Z9S1asHn6ZK3YqDQ> <xmx:XaDrXMYTAWKaKliTEpnTer0oNE7K2GhUcKpO62MBFGDEVdup46O2YQ> <xmx:XaDrXJwZ42i4m0sr7u73nPCUP6WjRCjBDr3Dck7A39Ol_cC5QNB-0Q> <xmx:XqDrXOgGgmgJvxjdTyYOpMiXpSGRSrWMI4rKou1EAYb853IRWJdGCQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6E3B0380085; Mon, 27 May 2019 04:31:24 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, matan@mellanox.com, Stephen Hemminger <sthemmin@microsoft.com> Date: Mon, 27 May 2019 10:31:22 +0200 Message-ID: <2413717.vlMEc98STl@xps> In-Reply-To: <20190524150617.6b0246ae@hermes.lan> References: <20190523220124.18818-1-stephen@networkplumber.org> <2097372.dQ5myFMioY@xps> <20190524150617.6b0246ae@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 25/05/2019 00:06, Stephen Hemminger: > On Fri, 24 May 2019 19:32:14 +0200 > Thomas Monjalon <thomas@monjalon.net> wrote: > > 24/05/2019 19:11, Stephen Hemminger: > > > On Fri, 24 May 2019 19:05:20 +0200 > > > Thomas Monjalon <thomas@monjalon.net> wrote: > > > > > > > > > > device drivers on Hyper-V/Azure. If the build system supported dependencies > > > > > > > (like Linux kbuild) this would not be necessary. Meson only does dynamic dependencies > > > > > > > so that doesn't help. > > > > > > > > > > > > > > This is a warning and not fatal only because application will still at > > > > > > > least run, and somebody may want to run with SR-IOV with Intel NIC's on Hyper-V. > > > > > > > > > > > > > > > > > > > > > The warning is just to give users better immediate feedback rather than > > > > > > > trying to diagnose poor performance or mystery device not found messages. > > > > > > > > > > > > > > > > > > It really looks strange to me. > > > > > > What you need is to fail at compilation if requested PMD is not built. > > > > > > I would advise to work on a script to configure meson. > > > > > > > > > > None of the people that ran into this were using meson build. > > > > > For example, VPP doesn't use meson. > > > > > > > > They will use meson when makefile will be removed :) > > > > > > > > Anyway, no matter the build system, what we want is a way > > > > to guide users to a proper DPDK installation. > > > > Your solution is to add some very specific logs. > > > > My proposal is to guide the user with a script and some > > > > specific parameters so it will fail if a required dependency is not met. > > > > > > Not familiar enough with meson magic syntax to make vdev_netvsc not build > > > without MLX. But that would just be pushing the mystery failure further > > > down the road. > > > > I think you did not understand my proposal. > > Let's take an example. You give this instruction to build DPDK: > > buildtools/build-require.sh vdev_netvsc mlx4 > > There is no build-require.sh now and introducing yet another tool > is not going to help. I disagree. I think we are missing this tool. > > If mlx4 is not built then it will fail with this message: > > librte_pmd_mlx4 failed to build > > So the user knows what went wrong. No mystery. > > > > > > > Another alternative would be to drop vdev_netvsc from the default Linux > > > build. That way users would have to enable it manually. > > > > > > My preferred solution would be to just kill vdev_netvsc and go to only netvsc PMD > > > but that is a couple releases away. > > Let's just fix the meson.build for now to skip vdev_netvsc unless both mlx4 and mlx5 are present. This is not a fix but a hack. Why vdev_netvsc would need mlx PMDs? Because it is the Azure config? > The Makefile can just remain untouched. > The people with problem are on older releases anyway. So any attempt to fix > the Makefiles won't help those on 18.02, etc.