From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D13B748933; Tue, 14 Oct 2025 11:55:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78FD4402AE; Tue, 14 Oct 2025 11:55:19 +0200 (CEST) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id AF577402A8 for ; Tue, 14 Oct 2025 11:55:17 +0200 (CEST) Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 52A9614001DD; Tue, 14 Oct 2025 05:55:17 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Tue, 14 Oct 2025 05:55:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1760435717; x=1760522117; bh=agSGWA5ItL5V1YQfjpOrH/8OHG0P4s2fEQtJBEVzrmU=; b= Foh9lm0A8wIkL7qKO6XWbsOjmMdz9jhZ5qz/fAKk9CyTsEIHyl10HIwRyXfadVwV t9Thy6DLW0iNXDbXj0nk83iClR3+1srh27Kq5geVBvRQ2DhO+RNNn4mMrOR7Txm6 tMoK9hcSuCxBOVvMF2Gvfk3SKzffTKINC0nOOt3lco0Cn97xKa1xRKfx93pKIKdh 39Q3fvl4DFklZyTvPzAA6zh3znztvOcZMMpI0GYrzvSigUvqz6Gxa+WRbjei887H vqm8Gq2EJLGtTyy/tYMAK4Tv9j7sLKi/DasS0d0luWle/Tx/eZQwz76G8KK64YEH vxWpghw+YK6meliBGbVpzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1760435717; x= 1760522117; bh=agSGWA5ItL5V1YQfjpOrH/8OHG0P4s2fEQtJBEVzrmU=; b=a Cmblzlj53syFu+mrsYgCby6t+scJrJRL8p1Bsupux08HVEi9YKA9g5stNRB13lgu XtAGaLZ0ZtFbHL36LEMjbo0QSscZSa3ytJylNAUj+BLY1KCn34wnQhTPri16QO0i sBhJkVus8w+2s2TwUtqDXt+GIaFukDmEDYkMcdD5L2Hl6Fo8QnzY3Dx2VTz6koTN 0J36Nnw2q9PjlflGFgFFBn8ebqpAf0wUxx+wWoK7tuM6Higa1RmAXxBQlTiFyXuf Y26SQ0DrDZXDdoCZvc2FnAJurhFO2cFptDCtOwCnN2iST0ElVtybmBwa/v2p2WUe sGZS//aPdH5zZ0+S0SpmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduvddtvddvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdeiuddv leevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeejpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopegsrhhutggvrdhrihgthhgrrhgushhonh esihhnthgvlhdrtghomhdprhgtphhtthhopehmsgesshhmrghrthhshhgrrhgvshihshht vghmshdrtghomhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgtphhtthhope hshhhpvghrvghtiiesnhhvihguihgrrdgtohhmpdhrtghpthhtohepvhhirggthhgvshhl rghvohesnhhvihguihgrrdgtohhmpdhrtghpthhtohepshhtvghphhgvnhesnhgvthifoh hrkhhplhhumhgsvghrrdhorhhgpdhrtghpthhtoheprghmrghnrdguvggvphdrshhinhhg hhesihhnthgvlhdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Oct 2025 05:55:15 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Morten =?UTF-8?B?QnLDuHJ1cA==?= , dev@dpdk.org, shperetz@nvidia.com, viacheslavo@nvidia.com, stephen@networkplumber.org, Aman Singh Subject: Re: [PATCH v5 6/7] app/testpmd: add commands to dump mbuf history Date: Tue, 14 Oct 2025 11:55:14 +0200 Message-ID: <2416987.8hzESeGDPO@thomas> In-Reply-To: References: <20250616072910.113042-1-shperetz@nvidia.com> <3472245.88bMQJbFj6@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/10/2025 11:48, Bruce Richardson: > On Tue, Oct 14, 2025 at 11:43:28AM +0200, Thomas Monjalon wrote: > > 14/10/2025 10:45, Morten Br=C3=B8rup: > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > Sent: Tuesday, 14 October 2025 08.59 > > > >=20 > > > > Dump the mbuf history to the console or to a file. > > > >=20 > > > > The dump will contain: > > > > - Operation history for each mbuf > > > > - Summary and statistics about all mbufs > > > >=20 > > > > Dump the history of all mbufs: > > > > testpmd> dump mbuf history all [file] > > > >=20 > > > > Dump the history of one mbuf pool: > > > > testpmd> dump mbuf history mempool [file] > > > >=20 > > > > Dump the history of one mbuf: > > > > testpmd> dump mbuf history one [file] > > >=20 > > > The "one" seems superfluous. I think this would suffice: > > > testpmd> dump mbuf history [file] > >=20 > > It's not superfluous :) > > Without it, the cmdline library cannot distinguish easily > > between > > dump mbuf history [file] > > and > > dump mbuf history mempool > >=20 > The latter might read better as "dump mbuf pool history ", which > would also resolve the ambiguity. I'll try that. > Even without cmdline lib resolving the ambiguity, it should be easy enough > for the cmdline callback to do strcmp() on the 4th parameter to check if > it's the string "mempool" and then direct appropriately. It is already doing strcmp(), but first, cmdline parsing must not be ambigu= ous.