From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 271CB4406A; Sun, 19 May 2024 15:54:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A46D44029C; Sun, 19 May 2024 15:54:22 +0200 (CEST) Received: from wfhigh2-smtp.messagingengine.com (wfhigh2-smtp.messagingengine.com [64.147.123.153]) by mails.dpdk.org (Postfix) with ESMTP id 708794028B for ; Sun, 19 May 2024 15:54:21 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.west.internal (Postfix) with ESMTP id 2D28318000EB; Sun, 19 May 2024 09:54:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 19 May 2024 09:54:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1716126858; x=1716213258; bh=SYYJHpsDJIAG/yX/54e/iqGT1jxXyOZMiZnrM1X7mB4=; b= A+DInBUW2X29Q0YtGiHNEa7ECOrNGAfTCt+nTbh5ATMiZx+zuvx5JgUDoFxnw2RQ qf+xgw7fJp7DB1xYKYczM4hq1Glk0DWt7HOsKZpkVX1yiKWkg3DmElkveRsHTb0M GCTquVAyv6EeB8fmNP5LTdT9DlZDfMZbbqFVObb29z8hWsYN0Y5Vmm4yajFmb7vc GcTvdVrkmv1+NBpCm+fPRsrYz1S9/vmh8/afI+anfGygyKevWlFM9871/x6cRfkh HqwwnQXNUhZP6t7++pTi9PHR4/o2fKiaIF7mAD+baqhyjHdTl7yXMT7iHaJPB0Yv fZL6+qjGQr0P1h2LfXrmBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716126858; x= 1716213258; bh=SYYJHpsDJIAG/yX/54e/iqGT1jxXyOZMiZnrM1X7mB4=; b=U I6SnsNlqs4S3hWeBHC07uTWLkD9Q9DHH12KWEbIJybGAbCiCxIi81niGdCj8qYmc /mA1bJELK07slAv4R48KkQ1vrHTxdTgJHBLIyJE3kZfYMEGilV458MeUJpbvzbLS TrC0ltZ8bOIhHus0m8/57YCSm1Zr700xRggxj580svRCZDCAi//0DOPIJ/PZTtnd fnKaha4o9CEIIutH71Ktem7BUXz1IQxAB1MPziqkQWzhvvhwkXULm2XKSzd4nEbR Y9D/wFg3cORwq+x1ZZEB1tauW1gXK10Z7i3VZYBGyx44FXTlQLfZAunLstS7tC3C lFMnOdNp0fgkOtMUXjL2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdehkedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 May 2024 09:54:17 -0400 (EDT) From: Thomas Monjalon To: Christian Ehrhardt , Luca Boccassi Cc: Bruce Richardson , dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH] doc: ensure sphinx output is reproducible Date: Sun, 19 May 2024 15:54:14 +0200 Message-ID: <24173311.ouqheUzb2q@thomas> In-Reply-To: References: <20230629125838.1995751-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/05/2024 13:29, Luca Boccassi: > On Mon, 27 Nov 2023 at 17:04, Bruce Richardson > wrote: > > > > On Mon, Nov 27, 2023 at 05:45:52PM +0100, Thomas Monjalon wrote: > > > 06/07/2023 14:49, Christian Ehrhardt: > > > > On Mon, Jul 3, 2023 at 5:29=E2=80=AFPM Thomas Monjalon wrote: > > > > > > > > > > 29/06/2023 14:58, christian.ehrhardt@canonical.com: > > > > > > From: Christian Ehrhardt > > > > > > > > > > > > By adding -j we build in parallel, to make building on multipro= cessor > > > > > > machines more effective. While that works it does also break > > > > > > reproducible builds as the order of the sphinx generated search= index.js > > > > > > is depending on execution speed of the individual processes. > > > > > [...] > > > > > > -if Version(ver) >=3D Version('1.7'): > > > > > > - sphinx_cmd +=3D ['-j', 'auto'] > > > > > > > > > > What is the impact on build speed on an average machine? > > > > > > > > Hi, > > > > I haven't tested this in isolation as it was just a mandatory change > > > > on the Debian/Ubuntu side. > > > > And the time for exactly and only the doc build is hidden inside the > > > > concurrency of meson. > > > > But I can compare a full build [1] and a full build with the change= [2]. > > > > > > > > That is an average build machine and it is 35 seconds slower with t= he > > > > change to no more do doc builds in parallel. > > > > > > I would prefer adding an option for reproducible build > > > (which is not a common requirement). > > > > > Taking a slightly different tack, is it possible to sort the searchinde= x.js > > file post-build, so that even reproducible builds get the benefits of > > parallelism? >=20 > Given the recent attacks with malicious sources being injected in open > source projects, reproducible builds are more important than ever and > should just be the default. Yes it should be the default when packaging. Why should it be the default for normal builds? > Could we please take this patch as-is? It's a pity nobody tried a different approach. Considering the activity on this, it does not look a high priority. > If someone wants to try and fix this searchindex.js in a different way > separately it can then be done later and on top of this. Removing something and ask others to re-add it later is a strange reasoning= =2E