Re: [dpdk-dev] [PATCH v3] rte_delay_us can be replaced with user function

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-09-23 08:39, jozmarti@cisco.com:
> --- a/lib/librte_eal/common/include/generic/rte_cycles.h
> +++ b/lib/librte_eal/common/include/generic/rte_cycles.h
> @@ -180,15 +180,17 @@ rte_get_timer_hz(void)
>  	default: rte_panic("Invalid timer source specified\n");
>  	}
>  }
> -
>  /**
> + *
>   * Wait at least us microseconds.
> + * This function can be replaced with user-defined function.
> + * @see rte_delay_us_callback_register
>   *
>   * @param us
>   *   The number of microseconds to wait.
>   */
>  void
> -rte_delay_us(unsigned us);
> +(*rte_delay_us)(unsigned int us);
>  
>  /**
>   * Wait at least ms milliseconds.
> @@ -202,4 +204,22 @@ rte_delay_ms(unsigned ms)
>  	rte_delay_us(ms * 1000);
>  }
>  
> +/**
> + * Blocking delay function.
> + *
> + * @param us
> + *   Number of microseconds to wait.
> + */
> +void rte_delay_us_block(unsigned int us);
> +/**
> + * Replace rte_delay_us with user defined function.
> + *
> + * @param userfunc
> + *   User function which replaces rte_delay_us. NULL restores
> + *   buildin block delay function.
> + */

The comment about NULL value is not valid anymore.

> +void rte_delay_us_callback_register(void(*userfunc)(unsigned int));
> +
> +
> +
>  #endif /* _RTE_CYCLES_H_ */

There are extra or missing blank lines in this chunk.
Except these and the above comment, it looks good to me.