From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 648CC1B733 for <dev@dpdk.org>; Tue, 24 Oct 2017 11:38:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C3BCA20F77; Tue, 24 Oct 2017 05:38:52 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 24 Oct 2017 05:38:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Y9ZoeN2IggveOYax5bab3HWbuj CzZG12ATcwGUFSL0I=; b=dCDn7hg5lRQu9pBeam06XfeHy0LfhLnrJokweZPhzC +rgJS6fdlUnoXAXQI6ErbBtm5BV0PZ55R0b+dY2MhKSNc0P0dErOj+7Xmtyzj1Ea o6kSUtkaRwFLD/ss9DVTFGzXrVVvbX1GTEIVy9Xx/wXnSxrU7HXsjV+huXbuD04c Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Y9ZoeN 2IggveOYax5bab3HWbujCzZG12ATcwGUFSL0I=; b=TPJSk6gIKHsZlPJjTRB14u N6luOiEkUq/nddIaSOBZ3W1R36UlbFL5brXmjDyxR5l86DjIWl1lSxzslGeFEEM9 cMh8LgSbQrOuFbNPVBwjBtCjanYBXMEEf3u1dh6TnWfIIdSv/XY2Q9lWvpdbu7RM U5AloEO0zqVZVIB1VikkzS8QCN3SlpUbgNanPVxIwXQs14q1FKIUNgFeaZ2/1/1G dX5u5IhULpDNTc4o8SLNY8xGHfh1gPrDVKjAB/OJCzvq9W+KCoB1b42/PJjUmpcP +vjLDGxitUmoUVCayEZ6V0eA1HFtfzb9T0lRvWr/26aSP+P+8eFGMoKBLNMPdcww == X-ME-Sender: <xms:LArvWbUoBvk_8grQ-ZSmDytVh3ZVrHpsYM_D9Vf7Twt9GnRpeBOW0A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 712657F94D; Tue, 24 Oct 2017 05:38:52 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Mcnamara, John" <john.mcnamara@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com> Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com> Date: Tue, 24 Oct 2017 11:38:51 +0200 Message-ID: <2419109.dR6RbCMRoY@xps> In-Reply-To: <B27915DBBA3421428155699D51E4CFE23EDE2EB6@IRSMSX103.ger.corp.intel.com> References: <1508679124-5922-1-git-send-email-bernard.iremonger@intel.com> <8CEF83825BEC744B83065625E567D7C24E055559@IRSMSX108.ger.corp.intel.com> <B27915DBBA3421428155699D51E4CFE23EDE2EB6@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 0/4] flow classification library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 24 Oct 2017 09:38:53 -0000 24/10/2017 11:23, Mcnamara, John: > From: Iremonger, Bernard > > > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > I suppose you are OK to wait one more release and call for more > > reviewers? > > > > This library was not ready for 17.11.RC1 having received some comments > > just before the RC1 deadline. > > It was then targeted for RC2 and we have pulled out all the stops to get > > it ready for RC2. > > > > It is now at v10 of the patch set, there have been no review comments from > > the community (apart from Intel), since RFC v3. > > > > I think that there has been ample time for the community to review this > > patch set, calling for more reviewers at this point is not helpful. I have to review some basic things in your series. I did not take time to review it because I thought John told me it would not make 17.11. > > The API's of the library are marked as experimental, so there will be no > > issues with ABI breakage, if there are requests for changes later. It is not marked EXPERIMENTAL in the MAINTAINERS file. > > I am not OK to wait one more release, I believe we have followed the > > process correctly. Yes, you followed the process. > +1 for inclusion in RC2. It is not common to add a new library in RC2. When doing the RC1 announce, I did not mention this library as a possible inclusion exception in RC2, and I had no feedback: http://dpdk.org/ml/archives/announce/2017-October/000153.html I was really sure you were not targetting 17.11. So I did not do the last pass review. Probably my mistake. We are having a hard time with 17.11 release, so I would prefer avoiding adding one more new library at this stage.