From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07DD9A057B; Thu, 2 Apr 2020 11:38:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAD182BCE; Thu, 2 Apr 2020 11:38:23 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 7E2BC2BAF for ; Thu, 2 Apr 2020 11:38:22 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id DDFFC580248; Thu, 2 Apr 2020 05:38:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 02 Apr 2020 05:38:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=lCw4BEHy9B3QIzIktWXhuzCWXNaxyPD8dINofgadf04=; b=VaqOi+RvO/sl VenqkJGoL3hJVNwpBW0uUzE7noL/Lrvemjd88ugdyhWzHJaImNTvGbGowxWNmkSU BMuqqxKqZQHM+Q+oi0CDVEwzn2iCjnRlHhjKkJaBLyujxpi+aB8x3aVH9JbFoNuj fRect5IkijK+VfbNetLkox10haRcFQg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=lCw4BEHy9B3QIzIktWXhuzCWXNaxyPD8dINofgadf 04=; b=XaxnDcPXtSkgt+j8vNkIcgS5q5YkOQB0+dIT35A/3ySDwcKhXB8AR3rsq S1hG16cpnqOo/71FTRBP9agj1DbslsCet0yBL2OLgV6P4v4i5EOen7BsEYILVoh0 kbmYJLKaFVp0tIpeTsz9c9PQ5k4kc0kAJ7OB4Kw5nrMFgYzEy3eHD8Q5/NklesIv CTqO4WOQDNP6TALt/u/vje37otlypuzEnKVVksxFRqlLPnMVQxZspTJLgEf+SuOe byjWw4RbSd7tsoByvHayOOvltCgo6GsNkaD85wX2owb4NDCkkpoi2Yiee7RrSVLA uOOoiQ16w1z5pm1ux9UGZ4HFah0Gw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeggddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 95BD63280063; Thu, 2 Apr 2020 05:38:17 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , David Marchand , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: Ciara Power , Kevin Laatz , dev , "Pattan, Reshma" , Harry van Haaren , Jerin Jacob Kollanukkaran , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Sunil Kumar Kori , "Yigit, Ferruh" , Andrew Rybchenko , Declan Doherty , Olivier Matz , Neil Horman , Ray Kinsella Date: Thu, 02 Apr 2020 11:38:16 +0200 Message-ID: <2419430.VnKG3xVv5R@xps> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60F32@smartserver.smartshare.dk> References: <20200319171907.60891-1-ciara.power@intel.com> <20200401161607.GA152@bricha3-MOBL.ger.corp.intel.com> <98CBD80474FA8B44BF855DF32C47DC35C60F32@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH 00/12] update and simplify telemetry library. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/04/2020 10:30, Morten Br=F8rup: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, April 1, 2020 6:16 PM > >=20 > > On Wed, Apr 01, 2020 at 05:42:21PM +0200, David Marchand wrote: > > > Hello, > > > > > > On Thu, Mar 19, 2020 at 6:35 PM Ciara Power > > wrote: > > > > > > > > This patchset extensively reworks the telemetry library adding new > > > > functionality and simplifying much of the existing code, while > > > > maintaining backward compatibility. >=20 > [...] > =20 > > > Is there a reason to keep a separate telemetry library rather than > > > integrate this framework into EAL? > > > > > No reason this could not be done, however, since telemetry library is > > already separate, and EAL is already pretty crowded, I think keeping > > this > > separate might lead to easier maintenance. > >=20 > > However, if people generally prefer it just merged into EAL, that can > > be > > done also. > >=20 >=20 > No! EAL is the Environment Abstraction Layer. EAL should only provide the= common abstraction interface for the different hardware/hypervisors and op= erating systems that may lie beneath the DPDK application, and nothing else. >=20 > If there is consensus that everyone absolutely needs some feature, which = is not an abstraction of the underlying execution environment, it should be= in a "Common" (or "Framework" or "Support") library instead. >=20 > EAL is already way too bloated. I agree. We should move some features from EAL to a separate library. > Take Service Cores for instance: It doesn't provide a shim for the underl= ying execution environment; it provides a process scheduling framework, whi= ch is optional for the DPDK application to use or not. >=20 > The same goes for the Trace library. Not a shim, but a framework library. >=20 > Logging is even worse: It logs to a file, but if it was truly an environm= ent abstraction, it would log to the Event Log on Windows. In other words..= =2E Logging is not implemented as an environment abstraction, but at the pr= eference of its implementer. I would consider it a core/framework library, = not an EAL library. Logging should be an OS abstraction, yes. So logging must stay in EAL.